30486[TASK] Add a system check for external downloads
Commit message
Review
-
Code review CR +2
- Xavier Perseguers +2
- Stefan Neufeind +1
- Wouter Wolters +1
- Marcin Sągol +1
- Fabien Udriot +1
-
Verified V +2
- Xavier Perseguers +2
- Wouter Wolters +1
Issues 1
Files 1
Review log 15
-
Wouter Wolters voted on patch set 1 V +1 CR +1 05/29/14, 13:07
-
Stefan Neufeind commented on patch set 1 05/29/14, 13:07
I'm not sure about the wording "possible". How about "allowed"? It's more a check if the possibilities are technically enabled - not really if they are really "possible". But adding a real check for reachability to TER also imho isn't really a great idea and would involve too much work. The aim of your check (configuration at least correct) imho is okay. -
Mr. Jenkins commented on patch set 1 05/29/14, 13:15
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16567/ : SUCCESS -
Markus Klein commented on patch set 1 05/29/14, 13:16
I agree the wording is not perfect. Will try to improve that -
Markus Klein uploaded patch set 2 05/29/14, 13:17
-
Mr. Jenkins commented on patch set 2 05/29/14, 13:32
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16568/ : SUCCESS -
Stefan Neufeind commented on patch set 2 CR +1 05/29/14, 13:34
Check.php:414If we agree on "allowed", maybe we should also adjust the function-name. But that's just internals anyway. I'm fine with the solution for now ... Let's see what others think. -
Wouter Wolters voted on patch set 2 V +1 CR +1 05/29/14, 13:49
-
Fabien Udriot voted on patch set 2 CR +1 06/11/14, 21:39
-
Marcin Sągol voted on patch set 2 CR +1 06/11/14, 21:43
-
Xavier Perseguers commented on patch set 2 V +2 CR +2 06/12/14, 07:05
Check.php:414Replythat's fine as it's internal -
Xavier Perseguers merged patch set 3 06/12/14, 07:05
-
Christian Kuhn commented on patch set 3 06/16/14, 14:15
post -1Check.php:416post -1: SystemEnvironment MUST NOT access TYPO3_CONF_VARS or something like that. See comment in head of class: * The class *must not* check for any TYPO3 specific things like * specific configuration values or directories. It should not fail * if there is no TYPO3 at all. -
Markus Klein commented on patch set 3 06/16/14, 14:28
Check.php:416ReplyOk, revert? On the other hand, it will never fail and I know no other place where we can check this. It is crucial for installation. -
Christian Kuhn commented on patch set 3 06/29/14, 21:56
post -2. The patch adds access to TYPO3 specific $GLOBALS variables which is NOT allowed in this class.