Review main Merged

3052[TASK] Rename reference to php locallang files

Georg Ringer CR +2 V +2 Easy +18 −18 updated 06/03/13, 20:49

Commit message

Even when the locallang file is a xml file
already, there are still the references to php
files.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Björn Pedersen +1
  • Verified V +2
    • Christian Kuhn +2
    • Björn Pedersen +1

Issues 1

Files 18

Review log 7

  1. Björn Pedersen voted on patch set 1 V 0 07/07/11, 16:19

  2. Björn Pedersen commented on patch set 1 07/07/11, 16:19

    Looks good to me, but someone else must approve
  3. Stefan Neufeind commented on patch set 1 07/07/11, 16:19

    Looks good to me, but someone else must approve if all those XMLs already exist now, change makes sense.
  4. Christian Kuhn commented on patch set 1 07/07/11, 16:19

    Verified; Looks good to me, but someone else must approve Obvious, clear +1. This is a no-brainer, please go ahead and submit. BTW Georg, you should fix your git author field to your full name ;)
  5. Christian Kuhn commented on patch set 1 V 0 07/07/11, 16:19

    by team member; Looks good to me, approved
  6. Mr. Jenkins commented on patch set 1 07/07/11, 16:19

  7. Christian Kuhn merged patch set 1 07/07/11, 16:19