30526[BUGFIX] Guard FAL API when called with invalid identifiers
Commit message
Review
-
Code review CR +2
- Steffen Ritter +2
- Fabien Udriot +1
-
Verified V +2
- Steffen Ritter +2
- Fabien Udriot +1
Issues 1
Files 3
Review log 13
-
Helmut Hummel uploaded patch set 2 06/02/14, 18:22
-
Helmut Hummel uploaded patch set 3 06/02/14, 18:23
-
Helmut Hummel commented on patch set 3 06/02/14, 18:24
-
Mr. Jenkins commented on patch set 1 CR -1 V -1 06/02/14, 18:35
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/16593/ : FAILURE -
Mr. Jenkins commented on patch set 2 CR -1 V -1 06/02/14, 18:36
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/16594/ : FAILURE -
Mr. Jenkins commented on patch set 3 CR -1 V -1 06/02/14, 18:49
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/16595/ : FAILURE -
Markus Klein commented on patch set 3 06/02/14, 19:26
LocalDriver.php:270Replydoesn't it suffice to use only is_file then?ResourceFactory.php:382are these two variables checked in getFileObjectByStorageAndIdentifier() then? -
Krzysztof Adamczyk uploaded patch set 4 06/11/14, 06:54
-
Mr. Jenkins commented on patch set 4 06/11/14, 07:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16636/ : SUCCESS -
Steffen Ritter voted on patch set 4 V +1 CR +1 06/11/14, 09:00
-
Fabien Udriot voted on patch set 4 V +1 CR +1 06/11/14, 09:31
-
Steffen Ritter voted on patch set 4 V +2 CR +2 06/11/14, 09:50
-
Steffen Ritter merged patch set 5 06/11/14, 09:50
LocalDriver.php:270