Review main Merged

30534[BUGFIX] Detect missing files in empty storage

Robert Vock CR +2 V +2 Easy +14 −14 updated 07/07/14, 06:32

Commit message

Improve the check for missing files by properly treating
the case when a storage is empty.

Review

  • Code review CR +2
    • Frans Saris +2
    • Markus Klein +1
    • Wouter Wolters +1
  • Verified V +2
    • Frans Saris +2
    • Markus Klein +1

Issues 1

Files 2

Review log 12

  1. Markus Klein uploaded patch set 2 06/03/14, 14:28

  2. Markus Klein commented on patch set 2 06/03/14, 14:34

    I slightly adjusted the patch, as there's no check in the other class whether the uidList is empty.
  3. Frans Saris voted on patch set 2 CR +1 06/04/14, 10:55

  4. Steffen Ritter voted on patch set 2 CR +1 06/11/14, 12:13

  5. Markus Klein updated the commit message in patch set 2 06/19/14, 20:07

  6. Markus Klein voted on patch set 3 V +1 CR +1 06/19/14, 20:09

  7. Mr. Jenkins commented on patch set 3 06/19/14, 20:27

  8. Wouter Wolters voted on patch set 3 CR +1 06/19/14, 21:29

  9. Frans Saris voted on patch set 3 V +1 CR +1 07/07/14, 06:29

  10. Frans Saris voted on patch set 3 V +2 CR +2 07/07/14, 06:31

  11. Frans Saris merged patch set 4 07/07/14, 06:31

  12. Frans Saris commented on patch set 4 07/07/14, 06:32

    Cherry Picked This patchset was cherry picked to change: I8fba9be2622a4cd742c0065b68a8daf77f8a484a