Review main Merged

30588[BUGFIX] Illegal string offset 'uid' in TypoScriptFrontendController

Robert Vock CR +2 V +2 Easy +1 −1 updated 06/05/14, 17:46

Commit message

Logoff sets user property to an empty string instead of NULL. This
leads to a PHP Warning in PHP 5.4

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1

Issues 1

Files 1

Review log 3

  1. Markus Klein commented on patch set 1 V +1 CR +1 06/05/14, 17:42

    Thanks for this patch! $user is documented to be array|NULL so this is a real no-brainer.
  2. Wouter Wolters voted on patch set 1 V +2 CR +2 06/05/14, 17:46

  3. Wouter Wolters merged patch set 2 06/05/14, 17:46