Review main Merged

30590[BUGFIX] Nested flexforms no longer throw exception

Thomas Christiansen CR +2 V +2 Easy +6 −2 updated 09/09/14, 11:05

Commit message

This patch prevents nested flexforms from throwing
an exception on saving or opening the record.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1

Issues 1

Files 2

Review log 16

  1. Thomas Christiansen uploaded patch set 2 06/05/14, 14:20

  2. Michael Knabe voted on patch set 2 V +1 CR +1 06/05/14, 14:22

  3. Thomas Christiansen uploaded patch set 3 06/05/14, 14:28

  4. Michael Knabe voted on patch set 3 V +1 CR +1 06/05/14, 14:31

  5. Wouter Wolters commented on patch set 3 06/05/14, 20:32

    rest of the code looks reasonable, but did not had a close look into the details

    DataPreprocessor.php:456

    else should be on the same line as the closing bracket
  6. Thomas Christiansen uploaded patch set 4 06/06/14, 06:49

  7. Christian Kuhn updated the commit message in patch set 4 06/20/14, 11:42

  8. Christian Kuhn commented on patch set 5 V +1 CR +1 06/20/14, 11:51

    ReferenceIndex.php:513

    assignments in if are discouraged ... but well ... ok for now, imho.
  9. Mr. Jenkins commented on patch set 5 06/20/14, 11:57

  10. Christian Kuhn commented on patch set 5 06/20/14, 12:07

    codewise safe
  11. Christian Kuhn uploaded patch set 6 06/20/14, 12:08

  12. Christian Kuhn voted on patch set 6 V +1 CR +1 06/20/14, 12:08

  13. Anja Leichsenring voted on patch set 6 V +2 CR +2 06/20/14, 12:10

  14. Anja Leichsenring merged patch set 7 06/20/14, 12:10

  15. Mr. Jenkins commented on patch set 6 06/20/14, 12:32

  16. Anja Leichsenring commented on patch set 7 09/09/14, 11:05

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 0a9fd7a92085a62eccbc7652a69befbe6c85968a