30590[BUGFIX] Nested flexforms no longer throw exception
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Christian Kuhn +1
-
Verified V +2
- Anja Leichsenring +2
- Christian Kuhn +1
Issues 1
Files 2
Review log 16
-
Thomas Christiansen uploaded patch set 2 06/05/14, 14:20
-
Michael Knabe voted on patch set 2 V +1 CR +1 06/05/14, 14:22
-
Thomas Christiansen uploaded patch set 3 06/05/14, 14:28
-
Michael Knabe voted on patch set 3 V +1 CR +1 06/05/14, 14:31
-
Wouter Wolters commented on patch set 3 06/05/14, 20:32
rest of the code looks reasonable, but did not had a close look into the detailsDataPreprocessor.php:456else should be on the same line as the closing bracket -
Thomas Christiansen uploaded patch set 4 06/06/14, 06:49
-
Christian Kuhn updated the commit message in patch set 4 06/20/14, 11:42
-
Christian Kuhn commented on patch set 5 V +1 CR +1 06/20/14, 11:51
ReferenceIndex.php:513assignments in if are discouraged ... but well ... ok for now, imho. -
Mr. Jenkins commented on patch set 5 06/20/14, 11:57
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16876/ : SUCCESS -
Christian Kuhn commented on patch set 5 06/20/14, 12:07
codewise safe -
Christian Kuhn uploaded patch set 6 06/20/14, 12:08
-
Christian Kuhn voted on patch set 6 V +1 CR +1 06/20/14, 12:08
-
Anja Leichsenring voted on patch set 6 V +2 CR +2 06/20/14, 12:10
-
Anja Leichsenring merged patch set 7 06/20/14, 12:10
-
Mr. Jenkins commented on patch set 6 06/20/14, 12:32
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16880/ : SUCCESS -
Anja Leichsenring commented on patch set 7 09/09/14, 11:05
Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 0a9fd7a92085a62eccbc7652a69befbe6c85968a