30603[BUGFIX] Redirect on direct access to overlaid mountpoint
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Markus Klein +1
-
Verified V +2
- Anja Leichsenring +2
- Markus Klein +1
Issues 1
Files 2
Review log 19
-
Alexander Stehlik uploaded patch set 2 06/06/14, 08:57
-
Alexander Stehlik commented on patch set 2 06/06/14, 09:02
Removed dependency, rebased. -
Markus Klein commented on patch set 2 06/06/14, 09:37
I'm not to much into mount points, so I did only a code-wise review.TypoScriptFrontendController.php:1658use empty() here, which is fasterTypoScriptFrontendController.php:3198"exits" is a bit misleading IMHO. I'd assume to find an exit() or die() stmt in the code. -
Alexander Stehlik uploaded patch set 3 06/20/14, 17:44
-
Alexander Stehlik updated the commit message in patch set 3 06/20/14, 17:44
-
Mr. Jenkins commented on patch set 4 06/20/14, 17:59
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16901/ : SUCCESS -
Mr. Jenkins commented on patch set 3 06/20/14, 17:59
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16900/ : SUCCESS -
Markus Klein voted on patch set 4 CR +1 06/20/14, 18:09
-
Markus Klein voted on patch set 4 V +1 07/06/14, 22:40
-
Wouter Wolters voted on patch set 4 CR +1 07/07/14, 19:17
-
Markus Klein uploaded patch set 5 08/23/14, 15:12
-
Markus Klein uploaded patch set 6 08/23/14, 15:14
-
Markus Klein voted on patch set 6 CR +1 V +1 08/23/14, 15:14
-
Anja Leichsenring voted on patch set 6 CR +1 V +1 09/13/14, 21:03
-
Markus Klein uploaded patch set 7 09/15/14, 21:53
-
Markus Klein commented on patch set 7 CR +1 V +1 09/15/14, 21:56
Rebased after tslib removal -
Anja Leichsenring voted on patch set 7 CR +2 V +2 09/17/14, 05:27
-
Anja Leichsenring merged patch set 7 09/17/14, 05:27
-
Alexander Stehlik commented on patch set 8 12/05/14, 18:11
This is currently not working correctly :( I posted a follow up bugfix at: https://review.typo3.org/#/c/35079/