Review main Merged

30608[TASK] Raise recommended max nesting level

Thomas Christiansen CR +2 V +2 Easy +1 −1 updated 06/20/14, 11:55

Commit message

Raise recommended max nesting level to 400 as 
the current value of 250 does not suffice.

Review

  • Code review CR +2
    • Markus Klein +2
    • Christian Kuhn +1
  • Verified V +2
    • Markus Klein +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 13

  1. Markus Klein commented on patch set 1 CR -1 06/06/14, 16:04

    Please have a look at our commit message rules. [1] Msg should be in present tense and please keep the change-id within the last paragraph. Update your commit-hook to the newest version. [2] [1] http://wiki.typo3.org/CommitMessage_Format_%28Git%29 [2] http://wiki.typo3.org/Contribution_Walkthrough_with_CommandLine#Setting_up_your_environment Thanks
  2. Markus Klein updated the commit message in patch set 1 06/06/14, 16:04

  3. Christian Kuhn voted on patch set 2 CR +1 06/06/14, 16:27

  4. Christian Kuhn commented on patch set 2 06/06/14, 16:28

    ok, but 400 should be max level as recommendation ... if this is still not enough, code may be structured differently to suppress such huge nestings.
  5. Anja Leichsenring commented on patch set 2 06/06/14, 16:32

    It might not be neccessary to increase the recommendated value. For single instances with higher demand you can always rise the value sky high, but this must not apply to the average instance.
  6. Thomas Christiansen commented on patch set 1 06/06/14, 17:04

    Reply

    Done, thanks!
  7. Christian Kuhn commented on patch set 2 V +1 06/20/14, 11:40

    Well, I've now had reports from several people that the 250 is not enough. I'd suggest to raise the recommendation a bit more as done in the patch. So +1 from me now.
  8. Christian Kuhn updated the commit message in patch set 2 06/20/14, 11:40

  9. Christian Kuhn voted on patch set 3 V +1 CR +1 06/20/14, 11:41

  10. Markus Klein voted on patch set 3 V +2 CR +2 06/20/14, 11:50

  11. Markus Klein merged patch set 4 06/20/14, 11:50

  12. Markus Klein commented on patch set 4 06/20/14, 11:51

    Cherry Picked This patchset was cherry picked to change: Ibccb61991809e24baddb21bd46f190cd0b8d907d
  13. Mr. Jenkins commented on patch set 3 06/20/14, 11:55