Review main Merged

30609[BUGFIX] Use delayedImportElement after uploading files

Frans Saris CR +2 V +2 Easy +1 −1 updated 06/07/14, 15:16

Commit message

When uploading multiple files in TCEForm the DrapUploader
adds all uploaded files directly to the inline element of the
form. But when a previous request isn't finished yet, it
breaks the processing of last request.

This patch changes the use of importElement to
delayedImportElement so the next element is only added
when the previous is processed.

Review

  • Code review CR +2
    • Markus Klein +2
    • Helmut Hummel +1
  • Verified V +2
    • Markus Klein +2
    • Marc Fell +1

Issues 3

Files 1

Review log 9

  1. Frans Saris updated the commit message in patch set 1 06/06/14, 14:18

  2. Markus Klein commented on patch set 2 06/06/14, 15:28

    We need one per line here for forge!
  3. Markus Klein updated the commit message in patch set 2 06/06/14, 15:29

  4. Markus Klein voted on patch set 3 CR +1 06/06/14, 15:29

  5. Helmut Hummel voted on patch set 3 CR +1 06/06/14, 17:58

  6. Helmut Hummel commented on patch set 3 06/06/14, 17:59

    Thanks Frans! Go ahead and merge this no-brainer if nobody objects in 24h ...
  7. Marc Fell commented on patch set 3 V +1 06/07/14, 15:09

    tested in IE, FF, GC -> works fine
  8. Markus Klein voted on patch set 3 V +2 CR +2 06/07/14, 15:16

  9. Markus Klein merged patch set 4 06/07/14, 15:16