Review main Abandoned

30634[BUGFIX] calcPerms exit too early

Stefan Froemken CR 0 V 0 Easy +1 −1 updated 12/18/14, 18:57

Commit message

Since issue #18797 the hook in calcPerms was not
called anymore. This is only the case if
BE module has no pagetree.
With this patch we add a check if current
BE module has a given UID or not.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 7

  1. Mr. Jenkins commented on patch set 1 06/10/14, 05:33

  2. Nicole Hummel commented on patch set 1 CR -1 06/10/14, 07:46

    I would recommend to abandon this patch as IMHO if there isn't any uid set there is something strange.
  3. Xavier Perseguers commented on patch set 1 CR -1 06/10/14, 10:44

    Same thoughts as Nicole
  4. Xavier Perseguers commented on patch set 1 06/10/14, 10:47

    So if I get it properly, the idea here would be to not let the Backend User access any sysfolder/page (page tree is empty) but still let it access the BE module provided by tc_beuser which in turn, overwrites the permissions... Slightly strange then, isn't it?
  5. Mathias Schreiber wrote 12/18/14, 08:18

    Topic set to BE Authentication
  6. Christian Kuhn commented on patch set 1 CR -2 12/18/14, 18:56

    I have the same concerns as Nicole and Xavier. This patch will not make it in its current incarnation. This somehow smells more like an conceptual issue in tc_beuser and not in calcPerms, I think. calcPerms always expects a *valid* row, if there is none, it is correct to return "no access", imho.
  7. Christian Kuhn abandoned the change 12/18/14, 18:57

    The patch in its current form will be abandoned now. A working solution should be discussed first, also aligning on the real problem, first.