30634[BUGFIX] calcPerms exit too early
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 7
-
Mr. Jenkins commented on patch set 1 06/10/14, 05:33
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16606/ : SUCCESS -
Nicole Hummel commented on patch set 1 CR -1 06/10/14, 07:46
I would recommend to abandon this patch as IMHO if there isn't any uid set there is something strange. -
Xavier Perseguers commented on patch set 1 CR -1 06/10/14, 10:44
Same thoughts as Nicole -
Xavier Perseguers commented on patch set 1 06/10/14, 10:47
So if I get it properly, the idea here would be to not let the Backend User access any sysfolder/page (page tree is empty) but still let it access the BE module provided by tc_beuser which in turn, overwrites the permissions... Slightly strange then, isn't it? -
Mathias Schreiber wrote 12/18/14, 08:18
Topic set to BE Authentication -
Christian Kuhn commented on patch set 1 CR -2 12/18/14, 18:56
I have the same concerns as Nicole and Xavier. This patch will not make it in its current incarnation. This somehow smells more like an conceptual issue in tc_beuser and not in calcPerms, I think. calcPerms always expects a *valid* row, if there is none, it is correct to return "no access", imho. -
Christian Kuhn abandoned the change 12/18/14, 18:57
The patch in its current form will be abandoned now. A working solution should be discussed first, also aligning on the real problem, first.