Review main Merged

30656[TASK] Activate 'Flush system caches' with Preset 'Development'

Zbigniew Jacko CR +2 V +2 Easy +9 −2 updated 06/11/14, 14:46

Commit message

Add a new configuration in Install Tool (['SYS']['clearCacheSystem']).
If set, the toolbar of clearing system cache is visible (only for
admin users).

Add it also for Configuration Preset. For Production it is set to FALSE,
for Development it is set to TRUE.

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Krzysztof Adamczyk +1
  • Verified V +2
    • Xavier Perseguers +2
    • Krzysztof Adamczyk +1

Issues 1

Files 6

Review log 14

  1. Mr. Jenkins commented on patch set 1 06/11/14, 09:45

  2. Steffen Ritter voted on patch set 1 CR +1 06/11/14, 09:46

  3. Xavier Perseguers updated the commit message in patch set 1 06/11/14, 09:48

  4. Krzysztof Adamczyk voted on patch set 2 V +1 CR +1 06/11/14, 10:02

  5. Xavier Perseguers uploaded patch set 3 06/11/14, 10:02

  6. Xavier Perseguers voted on patch set 3 V +1 CR +1 06/11/14, 10:02

  7. Krzysztof Adamczyk voted on patch set 3 V +1 CR +1 06/11/14, 10:03

  8. Mr. Jenkins commented on patch set 2 06/11/14, 10:04

  9. Xavier Perseguers commented on patch set 3 V +2 CR +2 06/11/14, 10:11

    Additionally taking into account +1 by Steffen in the first patch since only cosmetics in comments were changed. Thanks for contributing!
  10. Xavier Perseguers merged patch set 4 06/11/14, 10:11

  11. Mr. Jenkins commented on patch set 3 06/11/14, 10:16

  12. Markus Klein commented on patch set 4 06/11/14, 13:40

    ClearCacheToolbarItem.php:105

    ehm... CGL no space after cast codewise: why do we compare a bool against a bool to finally get a bool?
  13. Xavier Perseguers commented on patch set 4 06/11/14, 14:12

    ClearCacheToolbarItem.php:105 Reply

    Must admit I forgot about this CGL and I don't find it in http://docs.typo3.org/typo3cms/CodingGuidelinesReference/ Regarding the === TRUE it's redundant, I agree, but we have this construct at 6 other places in Core...
  14. Markus Klein commented on patch set 4 06/11/14, 14:46

    ClearCacheToolbarItem.php:105 Reply

    You're right; CGL is obviously missing this. Seems like this decision never made it into the document... ok, then it is of course ok. Well yes, the whole extbase code is full of this "mess". (KISS principle) Comparison for boolean is only necessary if you need to make a strict type check. (which is pretty useless for the code here if you cast bool first)