Review main Merged

30664[FEATURE] Display loading mask in Extension Manager

Zbigniew Jacko CR +2 V +2 Easy +2 −2 updated 06/12/14, 06:27

Commit message

Add a loading mask effect, whenever the User has clicked
on one of the two buttons of the compatibility check message
in the Extension Manager.

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Marcin Sągol +1
    • Fabien Udriot +1
    • Nicole Hummel +1
  • Verified V +2
    • Xavier Perseguers +2
    • Nicole Hummel +1

Issues 1

Files 1

Review log 14

  1. Xavier Perseguers voted on patch set 1 V +1 CR +1 06/11/14, 15:38

  2. Krzysztof Adamczyk voted on patch set 1 V +1 CR +1 06/11/14, 15:39

  3. Mr. Jenkins commented on patch set 1 06/11/14, 15:44

  4. Fabien Udriot updated the commit message in patch set 1 06/11/14, 16:08

  5. Fabien Udriot voted on patch set 2 CR +1 06/11/14, 16:08

  6. Mr. Jenkins commented on patch set 2 06/11/14, 16:22

  7. Bernhard Kraft commented on patch set 2 06/11/14, 19:49

    How can I test this?
  8. Bernhard Kraft commented on patch set 2 06/11/14, 20:00

    AFAIR I once saw this screen: http://forge.typo3.org/attachments/26894/em.png But right now I can't get to it again. How to provoke it?
  9. Xavier Perseguers commented on patch set 2 V +1 CR +1 06/11/14, 21:35

    To see it you need to have a local extension which does not meet the requirements (e.g., PHP and/or TYPO3) and that you try to load. You then see the warning message merged earlier today (screenshot mentioned) and when clicking the "I know what I do" button, you see the loading animation while the extension gets actually activated. Without the patch there is no animation.
  10. Marcin Sągol voted on patch set 2 CR +1 06/11/14, 21:43

  11. Nicole Hummel commented on patch set 2 06/11/14, 22:19

    @bernhard just uninstall the extension and try to install it again. After clicking either "Go back" button or proceed button the mask (overlay) should be visible
  12. Nicole Hummel voted on patch set 2 V +1 CR +1 06/11/14, 22:28

  13. Xavier Perseguers voted on patch set 2 V +2 CR +2 06/12/14, 06:27

  14. Xavier Perseguers merged patch set 3 06/12/14, 06:27