Review main Merged Breaking

30672[!!!][TASK] Use fallbacks for AbstractWidgetController view-configuration

Stefan Neufeind CR +2 V +2 Normal +116 −39 updated 07/15/15, 08:40

Commit message

The fallback-paths functionality offered by the parent class
is now available for Fluid-widgets.

Review

  • Code review CR +2
    • Markus Klein +2
    • Stefan Neufeind +1
    • Anja Leichsenring +1
  • Verified V +2
    • Markus Klein +2
    • Anja Leichsenring +1

Issues 1

Files 3

Review log 32

Show 7 earlier messages
  1. Stefan Neufeind commented on patch set 1 06/11/14, 20:39

    So far untested. Do you agree with this way of solving it? I know that backing up and restoring the configuration is a bit of a "hack" - but that allows us to use parent-functionality.
  2. Markus Klein updated the commit message in patch set 1 06/11/14, 20:47

  3. Mr. Jenkins commented on patch set 1 06/11/14, 20:50

  4. Mr. Jenkins commented on patch set 2 06/11/14, 21:09

  5. Alexander Opitz voted on patch set 2 CR +1 06/12/14, 12:39

  6. Markus Klein updated the commit message in patch set 2 06/19/14, 20:05

  7. Markus Klein commented on patch set 3 06/19/14, 20:07

    AbstractWidgetController.php:70

    shouldn't that be array_replace_recursive?
  1. Mr. Jenkins commented on patch set 3 06/19/14, 20:20

  2. Stefan Neufeind commented on patch set 3 06/19/14, 21:15

    AbstractWidgetController.php:70 Reply

    reading the php-documentation: Yes you're right. If not using numeric indexes the doc for array_merge_recursie reads the same/identical, doesn't it? Please adjust as needed and give it a try.
  3. Anja Leichsenring commented on patch set 3 V -1 CR -1 09/14/14, 11:34

    okay, this is too much hassle right now to fix properly. Before something happens here: - the change breaks tests (PHP Fatal Error) - it uses deprecated functions (it is templateRootPaths()) So please, even if the change itself is fine and dandy, do it right. Thanks
  4. Stefan Neufeind commented on patch set 3 09/14/14, 11:56

    Won't find the time to work on this again shortly :-( Could somebody take over maybe?
  5. Anja Leichsenring wrote 12/07/14, 20:19

    Removed the following approvals: * Code-Review-1 by Anja Leichsenring <aleichsenring@ab-softlab.de> * Verified-1 by Anja Leichsenring <aleichsenring@ab-softlab.de>
  6. Mathias Schreiber wrote 12/17/14, 14:33

    Topic set to EXT: fluid
  7. Markus Klein uploaded patch set 4 03/14/15, 21:02

  8. Markus Klein commented on patch set 4 CR +1 V +1 03/14/15, 21:03

    Could be breaking as templateRootPaths is required now (mind the s!)
  9. Markus Klein updated the commit message in patch set 5 03/14/15, 21:04

  10. Markus Klein voted on patch set 5 CR +1 03/14/15, 21:04

  11. Stanislas Rolland commented on patch set 5 03/18/15, 16:40

    AbstractWidgetController.php:77

    I think we need to add $this->extensionName as second parameter, otherwise the plugin view configuration is not retrieved.
  12. Markus Klein uploaded patch set 6 07/04/15, 01:31

  13. Markus Klein voted on patch set 6 CR +1 07/04/15, 01:31

  14. Stefan Neufeind voted on patch set 6 CR +1 07/06/15, 09:23

  15. Anja Leichsenring commented on patch set 6 CR +1 V +1 07/10/15, 09:37

    as much as I despice the cleanup patches, I wish you had split this change in two. Review is really hard, because the code changes drown in the Namespace shortage. Anyway, patch is fine.
  16. Stefan Neufeind commented on patch set 6 07/10/15, 09:44

    It wasn't me :-) And afaik the IDE of Markus does the shortenings pretty much automatic or so.
  17. Stefan Neufeind commented on patch set 6 07/13/15, 16:09

    Could somebody please take a look? Feel free to ask :-)
  18. Markus Klein voted on patch set 6 CR +2 V +2 07/13/15, 19:01

  19. Markus Klein merged patch set 6 07/13/15, 19:02

  20. Marc Bastian Heinrichs commented on patch set 7 07/14/15, 13:29

    Another crazy, but important to fix bug is caused by this patch https://forge.typo3.org/issues/68123
  21. Marc Bastian Heinrichs commented on patch set 7 07/14/15, 14:25

    It's a real regression and not only related to the configuration manager 1st level cache. See my comment.

    AbstractWidgetController.php:82

    The configuration you normally set, has nothing to do with the configuration you get by getConfiguration. In getConfiguration you get a plain array. setConfiguration is for a typoscriptArray. In getConfiguration is no extensionName and no pluginName, which was normally set in setConfiguration and causes really serious bugs inside the widget rendering now.
  22. Marc Bastian Heinrichs commented on patch set 7 07/14/15, 15:16

    After merge -2, -2

    AbstractWidgetController.php:82 Reply

    Sorry, not inside, but after this view configuration.
  23. Stefan Neufeind commented on patch set 7 07/14/15, 21:54

    Reverted This patchset was reverted in change: Ie86e38fbb42a029bd28e46f3b10ff3638ea21879
  24. Marc Bastian Heinrichs commented on patch set 7 07/15/15, 08:38

    Breaking-59505-UseFallbacksForAbstractWidgetControllerView-configuration.rst:20

    settings? view is a root property.
  25. Marc Bastian Heinrichs commented on patch set 7 07/15/15, 08:40