Review main Merged

30683[TASK] Add more files in gitignore file

Fabien Udriot CR +2 V +2 Easy +3 −0 updated 06/25/14, 16:42

Commit message

Whenever running the Functional Tests
directly from the Core, the framework requires
some additional folders that can be added
to the gitignore file.

More info about Functional Testing:
http://wiki.typo3.org/Functional_testing

Review

  • Code review CR +2
    • Markus Klein +2
    • Wouter Wolters +1
  • Verified V +2
    • Markus Klein +2

Issues 1

Files 1

Review log 14

  1. Mr. Jenkins commented on patch set 1 06/12/14, 08:18

  2. Wouter Wolters voted on patch set 1 CR +1 06/12/14, 12:39

  3. Fabien Udriot uploaded patch set 2 06/12/14, 13:55

  4. Fabien Udriot commented on patch set 2 06/12/14, 13:56

    Since the composer.lock file does not look to be shipped, ignore it as well. @see https://review.typo3.org/#/c/30684/
  5. Mr. Jenkins commented on patch set 2 06/12/14, 14:17

  6. Markus Klein commented on patch set 2 06/13/14, 07:12

    I would remove the lock file again. The discussion about it is not over yet.
  7. Fabien Udriot uploaded patch set 3 06/24/14, 08:41

  8. Fabien Udriot commented on patch set 3 06/24/14, 08:42

    Removed composer.lock from ignore file as suggested by Markus.
  9. Mr. Jenkins commented on patch set 3 06/24/14, 08:56

  10. Wouter Wolters voted on patch set 3 CR +1 06/24/14, 09:01

  11. Helmut Hummel commented on patch set 3 06/24/14, 23:04

    same as composer.lock, I think such a config would belong to the distribution meta repository (which we still not have). but on the other hand, if it helps somebody, I would not object to merge this anyway as it also does not harm
  12. Markus Klein voted on patch set 3 V +2 CR +2 06/25/14, 16:42

  13. Markus Klein merged patch set 4 06/25/14, 16:42

  14. Markus Klein commented on patch set 4 06/25/14, 16:42

    Cherry Picked This patchset was cherry picked to change: If51851f32ebeda0eb6829dc3f16d87709904824a