Review main Merged

3069[TASK] Remove tslib/publish.php

Christian Kuhn CR +2 V +2 Normal +18 −210 updated 06/03/13, 20:49

Commit message

The patch removes the script itself, together with the 'publish'
section in the admin panel since these features have been unmaintained
for the last few TYPO3 versions. Besides that it relies on the system
extension simulatestatic and is not compatible with e.g. RealURL.

Review

  • Code review CR +2
    • Steffen Gebert +2
  • Verified V +2
    • Steffen Gebert +2

Issues 1

Files 7

Review log 14

  1. Oliver Hader commented on patch set 1 07/07/11, 19:48

    (1 inline comment) Looks good so far... will check again
  2. Benni Mack commented on patch set 2 07/07/11, 19:48

    Looks good to me, but someone else must approve go for it!
  3. Oliver Hader uploaded patch set 2 07/07/11, 19:48

  4. Christian Kuhn commented on patch set 1 07/07/11, 19:48

    I'd say that jenkins is wrong with his vote here ...
  5. Christian Kuhn commented on patch set 1 07/07/11, 19:48

    (1 inline comment)
  6. Christian Kuhn commented on patch set 1 07/07/11, 19:48

    (1 inline comment)
  7. Christian Kuhn commented on patch set 2 07/07/11, 19:48

    Fine with me to just remove the deprecation, thanks Oliver!
  8. Georg Ringer commented on patch set 1 07/07/11, 19:48

    (1 inline comment) general +1 but see my comment

    config_default.php:726

    should we really do that? IMO this will lead to massive flooding of the log, even when the function is not used with current request...
  9. Steffen Gebert uploaded patch set 3 07/07/11, 19:48

  10. Steffen Gebert commented on patch set 3 V 0 07/07/11, 19:48

    by team member; Looks good to me, approved Added NEWS.txt entry
  11. Steffen Gebert merged patch set 3 07/07/11, 19:48

  12. Mr. Jenkins commented on patch set 1 07/07/11, 19:48

    Fails; I would prefer that you didn't submit this Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/912/ : FAILURE
  13. Mr. Jenkins commented on patch set 2 07/07/11, 19:48

  14. Mr. Jenkins commented on patch set 3 07/07/11, 19:48