3069[TASK] Remove tslib/publish.php
Commit message
Review
-
Code review CR +2
- Steffen Gebert +2
-
Verified V +2
- Steffen Gebert +2
Issues 1
Files 7
- t3lib/config_default.php4+1 −2
- typo3/sysext/cms/tslib/class.tslib_adminpanel.php+4 −57
- typo3/sysext/cms/tslib/class.tslib_fe.php+2 −2
- typo3/sysext/cms/tslib/index_ts.php+0 −10
- typo3/sysext/cms/tslib/publish.phpdeleted+0 −138
- typo3/sysext/simulatestatic/class.tx_simulatestatic.php+1 −1
- NEWS.txt+10 −0
Review log 14
-
Oliver Hader commented on patch set 1 07/07/11, 19:48
(1 inline comment) Looks good so far... will check again -
Benni Mack commented on patch set 2 07/07/11, 19:48
Looks good to me, but someone else must approve go for it! -
Oliver Hader uploaded patch set 2 07/07/11, 19:48
-
Christian Kuhn commented on patch set 1 07/07/11, 19:48
I'd say that jenkins is wrong with his vote here ... -
Christian Kuhn commented on patch set 1 07/07/11, 19:48
(1 inline comment) -
Christian Kuhn commented on patch set 1 07/07/11, 19:48
(1 inline comment) -
Christian Kuhn commented on patch set 2 07/07/11, 19:48
Fine with me to just remove the deprecation, thanks Oliver! -
Georg Ringer commented on patch set 1 07/07/11, 19:48
(1 inline comment) general +1 but see my commentconfig_default.php:726should we really do that? IMO this will lead to massive flooding of the log, even when the function is not used with current request... -
Steffen Gebert uploaded patch set 3 07/07/11, 19:48
-
Steffen Gebert commented on patch set 3 V 0 07/07/11, 19:48
by team member; Looks good to me, approved Added NEWS.txt entry -
Steffen Gebert merged patch set 3 07/07/11, 19:48
-
Mr. Jenkins commented on patch set 1 07/07/11, 19:48
Fails; I would prefer that you didn't submit this Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/912/ : FAILURE -
Mr. Jenkins commented on patch set 2 07/07/11, 19:48
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/924/ : SUCCESS -
Mr. Jenkins commented on patch set 3 07/07/11, 19:48
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/947/ : SUCCESS