30735[TASK] Extension manager: default sorting for Extensions
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Markus Klein +1
- Robert van Kammen +1
-
Verified V +2
- Wouter Wolters +2
- Markus Klein +1
- Robert van Kammen +1
Issues 1
Files 1
Review log 18
-
Mr. Jenkins commented on patch set 1 06/15/14, 09:27
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16720/ : SUCCESS -
Krzysztof Adamczyk voted on patch set 1 V +1 CR +1 06/15/14, 11:35
-
Marcin Sągol voted on patch set 1 CR +1 06/16/14, 10:38
-
Wouter Wolters updated the commit message in patch set 1 06/17/14, 18:40
-
Wouter Wolters voted on patch set 2 V +1 CR +1 06/17/14, 18:40
-
Marcin Sągol voted on patch set 2 CR +1 06/17/14, 19:34
-
Mr. Jenkins commented on patch set 2 06/17/14, 20:15
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16765/ : SUCCESS -
Christian Kuhn commented on patch set 2 06/19/14, 15:26
ExtensionRepository.php:63As far as I can see, this has effects on all methods that call getQuery() and do no setOrderings() on their own, so it *may* have unexpected side effects if we set setDefaultOrderings() in initializeObjects(). Which repo method is used for the extension list, is it used at other places and why is not a setOrderings() applied to the affected repo method only, or a new method introduced doing the ordering? -
Markus Klein commented on patch set 2 CR -1 06/19/14, 15:34
That should only apply to the non-filtered list. If I search for some extension, I want that ordered as it was. -
Susi Moog uploaded patch set 3 06/19/14, 16:16
-
Susi Moog commented on patch set 3 06/19/14, 16:18
I agree that the sorting should be done directly in the method responsible for the general list view - although the initialize version should not have any side effects, as all other methods have orderings set. -
Wouter Wolters commented on patch set 3 V +1 CR +1 06/19/14, 16:26
I agree here. Works for me -
Mr. Jenkins commented on patch set 3 06/19/14, 16:30
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16828/ : SUCCESS -
Markus Klein voted on patch set 3 V +1 CR +1 06/19/14, 16:36
-
Robert van Kammen commented on patch set 3 V +1 CR +1 06/19/14, 16:37
Tested it and it works. -
Wouter Wolters voted on patch set 3 V +2 CR +2 06/19/14, 16:38
-
Wouter Wolters merged patch set 4 06/19/14, 16:38
-
Wouter Wolters commented on patch set 4 06/19/14, 16:38
Cherry Picked This patchset was cherry picked to change: Ie8aebc13c41427e0603fa5313b794996d01fbc44