Review main Merged

30777[BUGFIX] Undefined method in extension manager

Oliver Hader CR +2 V +2 Easy +2 −3 updated 06/17/14, 14:05

Commit message

PHP fatal error due to the invalid call to non-existing method
ExtensionManagementService::resolveDependenciesAndInstall during
upgrading an existing extension to a newer version from TER.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Alexander Opitz +1
    • Francois Suter +1
  • Verified V +2
    • Oliver Hader +2
    • Alexander Opitz +1
    • Francois Suter +1

Issues 1

Files 2

Review log 9

  1. Alexander Opitz voted on patch set 1 V +1 CR +1 06/17/14, 13:40

  2. Alexander Opitz commented on patch set 1 V 0 CR 0 06/17/14, 13:44

    Need to take it back. The extension gets updated but an inactive extension will be activated while updating.
  3. Mr. Jenkins commented on patch set 1 06/17/14, 13:51

  4. Alexander Opitz commented on patch set 1 V +1 CR +1 06/17/14, 13:55

    Mentioned problem already exists in 6.2.2 so this is another issue.
  5. Francois Suter commented on patch set 1 V +1 CR +1 06/17/14, 13:57

    Thanks for fixing that annoying one! It helps that the EM is now reporting errors more explicitely ;-)
  6. Oliver Hader commented on patch set 1 06/17/14, 14:00

    @Alexander: The "install on update" behaviour was like that since the very beginning, see https://review.typo3.org/#/c/13612/3/typo3/sysext/extensionmanager/Classes/Controller/DownloadController.php,unified - line 192 for the "updateExtensionAction"... Albeit I agree that this is not optimal, it needs to be handled in a separate issue.
  7. Alexander Opitz commented on patch set 1 06/17/14, 14:04

    Reported that as issue: http://forge.typo3.org/issues/59631
  8. Oliver Hader voted on patch set 1 V +2 CR +2 06/17/14, 14:05

  9. Oliver Hader merged patch set 2 06/17/14, 14:05