30781[BUGFIX] Make FlexForm select replace makers in foreign_table_where clause
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 12
-
Mr. Jenkins commented on patch set 1 CR -1 V -1 06/17/14, 14:38
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/16744/ : FAILURE -
Tymoteusz Motylewski updated the commit message in patch set 1 06/20/14, 09:57
-
Tymoteusz Motylewski commented on patch set 2 06/20/14, 09:57
updated commit message to make jenkins happy and changed releases to supported versions -
Wouter Wolters commented on patch set 2 CR -2 06/20/14, 10:09
This is a duplicate of https://review.typo3.org/#/c/20901/ I added the same as this but this is the wrong approach as explained in my patch by Oliver Hader. My patch has a test extension from Susanne Moog. Can you please verify my patch instead. Thanks in advanced! Wouter -
Mr. Jenkins commented on patch set 2 06/20/14, 10:22
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16864/ : SUCCESS -
Claus Due commented on patch set 2 06/20/14, 10:26
The $field should be transferred - a hardcoded value of 'pi_flexform' is incorrect in this context since one record can have any number of 100% custom named flexform fields. -
Claus Due commented on patch set 2 06/20/14, 10:27
Also, pretty sure this is already merged: https://review.typo3.org/#/c/30633/ -
Claus Due voted on patch set 2 CR -1 06/20/14, 10:28
-
Wouter Wolters commented on patch set 2 06/20/14, 10:30
@Claus please check my comment. Your mentioned patch doesn't solve this problem:-) -
Claus Due commented on patch set 2 06/20/14, 10:48
@Wouter ah - your patch explains this patch. I'd use your patch ;) -
Sergio Catalá commented on patch set 2 06/21/14, 13:14
Thanks for the update. You're right, @Wouter. -
Wouter Wolters abandoned the change 07/06/14, 12:34
Review https://review.typo3.org/#/c/20901/ instead of this one.