Review main Abandoned

30781[BUGFIX] Make FlexForm select replace makers in foreign_table_where clause

Sergio Catalá CR 0 V 0 Easy +2 −2 updated 07/06/14, 12:34

Commit message

In the function renderRecord_SW() in 
typo3/sysext/backend/Classes/Form/DataPreprocessor.php it is mentioned
in the functions help declaration that $field is empty for flex forms.
That makes exec_foreign_table_where_query() function to fail and values 
of a field, even if they are properly
saved in the database, are not shown in the left part of a select 
field in flexforms.
The current patch tries to solve this problem.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 12

  1. Mr. Jenkins commented on patch set 1 CR -1 V -1 06/17/14, 14:38

  2. Tymoteusz Motylewski updated the commit message in patch set 1 06/20/14, 09:57

  3. Tymoteusz Motylewski commented on patch set 2 06/20/14, 09:57

    updated commit message to make jenkins happy and changed releases to supported versions
  4. Wouter Wolters commented on patch set 2 CR -2 06/20/14, 10:09

    This is a duplicate of https://review.typo3.org/#/c/20901/ I added the same as this but this is the wrong approach as explained in my patch by Oliver Hader. My patch has a test extension from Susanne Moog. Can you please verify my patch instead. Thanks in advanced! Wouter
  5. Mr. Jenkins commented on patch set 2 06/20/14, 10:22

  6. Claus Due commented on patch set 2 06/20/14, 10:26

    The $field should be transferred - a hardcoded value of 'pi_flexform' is incorrect in this context since one record can have any number of 100% custom named flexform fields.
  7. Claus Due commented on patch set 2 06/20/14, 10:27

    Also, pretty sure this is already merged: https://review.typo3.org/#/c/30633/
  8. Claus Due voted on patch set 2 CR -1 06/20/14, 10:28

  9. Wouter Wolters commented on patch set 2 06/20/14, 10:30

    @Claus please check my comment. Your mentioned patch doesn't solve this problem:-)
  10. Claus Due commented on patch set 2 06/20/14, 10:48

    @Wouter ah - your patch explains this patch. I'd use your patch ;)
  11. Sergio Catalá commented on patch set 2 06/21/14, 13:14

    Thanks for the update. You're right, @Wouter.
  12. Wouter Wolters abandoned the change 07/06/14, 12:34

    Review https://review.typo3.org/#/c/20901/ instead of this one.