30804[BUGFIX] Serialize expression in switch viewhelper
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Mathias Schreiber +1
- Stephan Großberndt +1
- Michael Oehlhof +1
-
Verified V +2
- Anja Leichsenring +2
- Mathias Schreiber +1
- Stephan Großberndt +1
Issues 1
Files 2
Review log 16
-
Mr. Jenkins commented on patch set 1 06/18/14, 08:43
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16782/ : SUCCESS -
Mathias Schreiber voted on patch set 1 CR +1 V +1 11/14/14, 18:17
-
Cedric Ziel voted on patch set 1 CR +1 V +1 12/04/14, 13:40
-
Cedric Ziel uploaded patch set 2 12/04/14, 14:05
-
Cedric Ziel commented on patch set 2 CR +1 V +1 12/04/14, 14:07
Adjusted Björns patch for master and class references. Will backport to 6.2 -
Anja Leichsenring updated the commit message in patch set 3 12/13/14, 16:06
-
Anja Leichsenring voted on patch set 3 CR +1 V +1 12/13/14, 16:06
-
Michael Oehlhof voted on patch set 3 CR +1 12/13/14, 17:29
-
Mathias Schreiber commented on patch set 3 CR +1 V +1 12/14/14, 09:18
I'm so damn sure we merged this one... -
Stephan Großberndt voted on patch set 3 CR +1 V +1 12/14/14, 17:01
-
Anja Leichsenring voted on patch set 3 CR +2 V +2 12/14/14, 17:06
-
Anja Leichsenring merged patch set 3 12/14/14, 17:06
-
Christian Kuhn commented on patch set 4 12/14/14, 18:11
sorry, but this "solution" looks exceptionally ugly at first glance and without digging too deep into the topic. there is now a concatenation between switch and case view helpers that is nowhere else. -
Anja Leichsenring commented on patch set 4 12/14/14, 18:14
Reverted This patchset was reverted in change: Ie9c97546934c995183552143bca29934a9611f93 -
Cedric Ziel commented on patch set 4 12/15/14, 12:32
@Björn can you jump in, as it's your patch originally? -
Björn Fromme commented on patch set 4 12/15/14, 12:40
> @Björn can you jump in, as it's your patch originally? I'm not sure what to do. I don't see where those viewhelpers get concatenated and why they shouldn't since one can't live without the other. But: if this patch should be abandoned I'm fine with it as well as the use of case/switch in Fluid templates is to be avoided anyway AFAIK.