30832[BUGFIX] ext_localconf.php may not exist
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 8
-
Francois Suter commented on patch set 1 06/18/14, 18:38
Note that it would also be possible to use "include" instead of "require", but that would still throw a PHP warning. This solution is cleaner. -
Francois Suter commented on patch set 1 06/18/14, 18:38
I consider this patch to be pretty much a no-brainer, but I'm leaving it open a bit for discussion, if needed. -
Markus Klein commented on patch set 1 06/18/14, 18:43
ExtensionManagementUtility.php:1524maybe even prefix with @ -
Mr. Jenkins commented on patch set 1 06/18/14, 18:55
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16799/ : SUCCESS -
Helmut Hummel commented on patch set 1 CR -1 06/18/14, 22:31
ExtensionManagementUtility.php:1520The check is here already. The question is: why is this set, if there is no ext_localconf.php -
Markus Klein commented on patch set 1 06/18/14, 22:44
ExtensionManagementUtility.php:1520ReplyGood point! Totally overlooked that. Code reference is LoadedExtensionArrayElement::initializeExtensionFiles(), here this array is initialized -
Helmut Hummel commented on patch set 1 06/18/14, 23:08
Don't know what your issue is Francois, but I cannot reproduce it and your fix is not correct like this.ExtensionManagementUtility.php:1520Replydouble checked. This array key is not set in LoadedExtensionArrayElement when the file does not exist. -
Francois Suter abandoned the change 06/20/14, 20:06
The problem does not lie where I thought it did. There's still an issue, but I don't have the time to investigate it now.