Review main Abandoned

30832[BUGFIX] ext_localconf.php may not exist

Francois Suter CR 0 V 0 Easy +3 −1 updated 06/20/14, 20:06

Commit message

An extension is not required to have an ext_localconf.php file.
Thus the ExtensionManagementUtility should consider this when
trying to include such file for all loaded extensions.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 8

  1. Francois Suter commented on patch set 1 06/18/14, 18:38

    Note that it would also be possible to use "include" instead of "require", but that would still throw a PHP warning. This solution is cleaner.
  2. Francois Suter commented on patch set 1 06/18/14, 18:38

    I consider this patch to be pretty much a no-brainer, but I'm leaving it open a bit for discussion, if needed.
  3. Markus Klein commented on patch set 1 06/18/14, 18:43

    ExtensionManagementUtility.php:1524

    maybe even prefix with @
  4. Mr. Jenkins commented on patch set 1 06/18/14, 18:55

  5. Helmut Hummel commented on patch set 1 CR -1 06/18/14, 22:31

    ExtensionManagementUtility.php:1520

    The check is here already. The question is: why is this set, if there is no ext_localconf.php
  6. Markus Klein commented on patch set 1 06/18/14, 22:44

    ExtensionManagementUtility.php:1520 Reply

    Good point! Totally overlooked that. Code reference is LoadedExtensionArrayElement::initializeExtensionFiles(), here this array is initialized
  7. Helmut Hummel commented on patch set 1 06/18/14, 23:08

    Don't know what your issue is Francois, but I cannot reproduce it and your fix is not correct like this.

    ExtensionManagementUtility.php:1520 Reply

    double checked. This array key is not set in LoadedExtensionArrayElement when the file does not exist.
  8. Francois Suter abandoned the change 06/20/14, 20:06

    The problem does not lie where I thought it did. There's still an issue, but I don't have the time to investigate it now.