Review main Merged

3088[BUGFIX] Exclude E_DEPRECATED from exceptionalErrors

Helmut Hummel CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

To avoid exceptions in case an extension uses PHP functions
that have been deprecated in PHP 5.3, E_DEPRECATED messages have to
also be excluded from $TYPO3_CONF_VARS['SYS']['exceptionalErrors']

Review

  • Code review CR +2
    • Steffen Gebert +2
    • Markus Klein +1
    • Philipp Gampe +1
  • Verified V +2
    • Steffen Gebert +2
    • Markus Klein +1
    • Philipp Gampe +1

Issues 1

Files 1

Review log 14

  1. Stefan Neufeind commented on patch set 1 07/07/11, 20:16

    Looks good to me, but someone else must approve sounds logic, 1-line-patch, ...
  2. Markus Klein commented on patch set 1 07/07/11, 20:16

    Verified; Looks good to me, but someone else must approve Hard to test, therefore also verfified.
  3. Steffen Gebert uploaded patch set 2 07/07/11, 20:16

  4. Markus Klein commented on patch set 3 07/07/11, 20:16

    Verified; Looks good to me, but someone else must approve
  5. Steffen Gebert commented on patch set 3 V 0 07/07/11, 20:16

    by team member; Looks good to me, approved
  6. Steffen Gebert uploaded patch set 3 07/07/11, 20:16

  7. Steffen Gebert merged patch set 3 07/07/11, 20:16

  8. Philipp Gampe commented on patch set 3 07/07/11, 20:16

    Verified; Looks good to me, but someone else must approve Works for me
  9. Philipp Gampe commented on patch set 3 07/07/11, 20:16

    Maybe I should mention that I did not test for a deprecated method. But I know from experience that it will work ;)
  10. Mr. Jenkins commented on patch set 1 07/07/11, 20:16

  11. Mr. Jenkins commented on patch set 2 07/07/11, 20:16

    Fails; I would prefer that you didn't submit this Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/942/ : FAILURE
  12. Mr. Jenkins commented on patch set 3 07/07/11, 20:16

    Fails; I would prefer that you didn't submit this Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/943/ : FAILURE
  13. Mr. Jenkins commented on patch set 3 07/07/11, 20:16

    No score; No score Removed voting manually
  14. Mr. Jenkins commented on patch set 3 07/07/11, 20:16