Review main Merged

30920[BUGFIX] language condition does not match exact string

Susi Moog CR +2 V +2 Easy +4 −2 updated 06/20/14, 15:18

Commit message

The documentation for conditions of type "language" states: "The values
must be a straight match with the value of getenv('HTTP_ACCEPT_LANGUAGE')
from PHP." (or you can use wildcards). Exact matches are actually
not working - and the unit test showing the problem was skipped.

Patch adds the feature as documented and adjusts the unit test.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1

Issues 1

Files 2

Review log 9

  1. Mr. Jenkins commented on patch set 1 06/20/14, 12:17

  2. Christian Kuhn commented on patch set 1 06/20/14, 14:57

    AbstractConditionMatcher.php:295

    strict comparison === ?
  3. Christian Kuhn commented on patch set 1 CR -1 06/20/14, 14:57

    working on it.
  4. Christian Kuhn uploaded patch set 2 06/20/14, 15:02

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 06/20/14, 15:04

  6. Wouter Wolters commented on patch set 2 V +1 CR +1 06/20/14, 15:06

    Unit-tests green for me
  7. Christian Kuhn voted on patch set 2 V +2 CR +2 06/20/14, 15:06

  8. Christian Kuhn merged patch set 3 06/20/14, 15:06

  9. Mr. Jenkins commented on patch set 2 06/20/14, 15:18