Review main Abandoned

30980[BUGFIX] Show NoTemplateFound message after action

Markus Hölzle CR 0 V 0 Easy +7 −9 updated 07/24/14, 19:01

Commit message

The error message that the template is missing was
shown before the extbase action was called.
So setTemplatePathAndFilename wasn't considered.
Now the message will be shown after the extbase
action, so the developer has a chance to change
the template path in the action.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 9

  1. Mr. Jenkins commented on patch set 1 06/20/14, 22:18

  2. Markus Klein voted on patch set 1 CR +1 06/20/14, 23:55

  3. Marcin Sągol voted on patch set 1 CR +1 07/05/14, 14:29

  4. Markus Klein commented on patch set 1 07/06/14, 21:31

    Asked for a test extension in the forge ticket
  5. Anja Leichsenring commented on patch set 1 CR -1 07/24/14, 09:37

    In extbase context, setTemplatePathAndFilename is no public API. You are to configure this via TypoScript, but not in the controller. The only use case, where you set the template on your own, is for Fluid Standalone View.
  6. Anja Leichsenring voted on patch set 1 CR -2 07/24/14, 09:38

  7. Christian Kuhn commented on patch set 1 CR -2 07/24/14, 18:44

    Thanks for the patch, Markus. The solution however is bogus since setTemplatePathAndFilename and stuff like that could be done in a "initializeFoobarAction()" or "initializeAction()" and not in the action itself. The patch is dropped therefor.
  8. Christian Kuhn abandoned the change 07/24/14, 18:45

  9. Markus Klein commented on patch set 1 07/24/14, 19:01

    Alright, thx for clarification!