Review main Merged

31008[TASK] Add a "save and new" button in scheduler module

Eric Chavaillaz CR +2 V +2 Easy +9 −2 updated 09/16/14, 09:43

Commit message

Review

  • Code review CR +2
    • Markus Klein +2
    • Stefan Froemken +1
  • Verified V +2
    • Markus Klein +2
    • Stefan Froemken +1

Issues 1

Files 2

Review log 18

  1. Mr. Jenkins commented on patch set 1 06/21/14, 17:12

  2. Philipp Gampe commented on patch set 1 06/21/14, 22:20

    Please split this up into two patches, one for the extension manager and one for the scheduler module. If you have trouble doing this, I can do this tomorrow.

    locallang_common.xlf:157

    I do not think this label is chosen right. You do not create a new form, but a new record. IMHO this should be moved to the scheduler extension locallang file and the label could be "Save and create new task". Or you keep it generic and call it "Save and create new record". "Form" sounds odd.
  3. Eric Chavaillaz uploaded patch set 2 06/23/14, 16:31

  4. Mr. Jenkins commented on patch set 2 06/23/14, 16:49

  5. Marcin Sągol commented on patch set 2 07/06/14, 11:44

    SchedulerModuleController.php:165

    Use === ?
  6. Christian Kuhn updated the commit message in patch set 2 07/06/14, 11:57

  7. Christian Kuhn commented on patch set 3 V -1 07/06/14, 12:05

    Thanks for your patch, this looks like a useful addition to align this module with other BE functionality. The patch however does not work for me correctly: If i edit an existing record and change some data, then hit "save and new", still the same record is open. Maybe you could have an additional look at this?
  8. Mr. Jenkins commented on patch set 3 07/06/14, 12:11

  9. Eric Chavaillaz commented on patch set 3 07/07/14, 07:10

    I will have a look when I will have some time. Thanks fot the review.
  10. Eric Chavaillaz uploaded patch set 4 09/15/14, 19:39

  11. Wouter Wolters uploaded patch set 5 09/15/14, 19:51

  12. Wouter Wolters commented on patch set 5 V +1 09/15/14, 19:53

    Resolved conflict. @Eric if you continue on a patch you can better use cherry-pick instead of a checkout of this patch. Your work was now based on an older version of ext:scheduler. The cherry-pick command resulted in a conflict, what I solved now. I'm not sure if we can get this into 6.2 and I'm undecided about the new label. IMO we can use the default value here.
  13. Eric Chavaillaz commented on patch set 5 09/15/14, 20:23

    Thanks for the resolution. I note for the next time to use cherry-pick instead of checkout.
  14. Eric Chavaillaz uploaded patch set 6 09/16/14, 05:41

  15. Eric Chavaillaz commented on patch set 5 09/16/14, 05:42

    Finally I agree with you for the label, the default one is enough. I just upload a new patch.
  16. Stefan Froemken voted on patch set 6 CR +1 V +1 09/16/14, 08:28

  17. Markus Klein voted on patch set 6 CR +2 V +2 09/16/14, 09:43

  18. Markus Klein merged patch set 6 09/16/14, 09:43