31040[TASK] Remove old and unused extension icons from t3skin
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Anja Leichsenring +1
- Susi Moog +1
-
Verified V +2
- Christian Kuhn +2
- Anja Leichsenring +1
- Susi Moog +1
Issues 1
Files 27
- typo3/sysext/t3skin/icons/ext/templavoila/mod1/clip_ref.pngdeletedbinary
- typo3/sysext/t3skin/icons/ext/templavoila/mod1/moduleicon.gifdeletedbinary
- typo3/sysext/t3skin/icons/ext/templavoila/mod1/moduleicon.pngdeletedbinary
- typo3/sysext/t3skin/icons/ext/tt_address/ext_icon.pngdeletedbinary
- typo3/sysext/t3skin/icons/ext/tt_address/ext_icon__h.pngdeletedbinary
- typo3/sysext/t3skin/icons/ext/tt_board/ext_icon.pngdeletedbinary
- typo3/sysext/t3skin/icons/ext/tt_board/ext_icon__h.pngdeletedbinary
- typo3/sysext/t3skin/icons/ext/tt_calender/ext_icon.pngdeletedbinary
- typo3/sysext/t3skin/icons/ext/tt_calender/ext_icon__h.pngdeletedbinary
- typo3/sysext/t3skin/icons/ext/tt_calender/ext_icon__ht.pngdeletedbinary
- typo3/sysext/t3skin/icons/ext/tt_calender/ext_icon__t.pngdeletedbinary
- typo3/sysext/t3skin/icons/ext/tt_calender/ext_icon__x.pngdeletedbinary
- typo3/sysext/t3skin/icons/ext/tt_guest/ext_icon.pngdeletedbinary
- typo3/sysext/t3skin/icons/ext/tt_guest/ext_icon__h.pngdeletedbinary
- typo3/sysext/t3skin/icons/ext/tt_news/ext_icon.pngdeletedbinary
- typo3/sysext/t3skin/icons/ext/tt_news/ext_icon__h.pngdeletedbinary
- typo3/sysext/t3skin/icons/ext/tt_news/ext_icon__ht.pngdeletedbinary
- typo3/sysext/t3skin/icons/ext/tt_news/ext_icon__htu.pngdeletedbinary
- typo3/sysext/t3skin/icons/ext/tt_news/ext_icon__hu.pngdeletedbinary
- typo3/sysext/t3skin/icons/ext/tt_news/ext_icon__t.pngdeletedbinary
Show 7 more files
- typo3/sysext/t3skin/icons/ext/tt_news/ext_icon__tu.pngdeletedbinary
- typo3/sysext/t3skin/icons/ext/tt_news/ext_icon__u.pngdeletedbinary
- typo3/sysext/t3skin/icons/ext/tt_news/ext_icon__x.pngdeletedbinary
- typo3/sysext/t3skin/icons/ext/user_photomarathon/photomarathon/user_pm_icon.pngdeletedbinary
- typo3/sysext/t3skin/icons/ext/user_photomarathon/photomarathon/user_pm_icon__h.pngdeletedbinary
- typo3/sysext/t3skin/icons/ext/user_photomarathon/tab_icon.gifdeletedbinary
- typo3/sysext/t3skin/icons/ext/user_photomarathon/tab_icon.pngdeletedbinary
Review log 13
-
Mr. Jenkins commented on patch set 1 06/22/14, 10:46
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16995/ : SUCCESS -
Krzysztof Adamczyk voted on patch set 1 V +1 CR +1 06/22/14, 17:10
-
Krzysztof Adamczyk voted on patch set 1 V 0 06/22/14, 17:19
-
Krzysztof Adamczyk commented on patch set 1 06/22/14, 17:20
Tymek, I'm not sure you did anything. You should also create new package with t3 images -
Krzysztof Adamczyk commented on patch set 1 06/22/14, 17:28
small update . instead of anything should be everything -
Jigal van Hemert commented on patch set 1 V -1 CR -1 06/22/14, 18:42
The first file I checked (icon-note.png) is still in use in typo3/sysext/sys_note/Configuration/TCA/sys_note.php . I haven't checked if anything outside the core relies on these icons, but it seems hardly worth the hassle of removing them. -
Tymoteusz Motylewski uploaded patch set 2 06/27/14, 16:29
-
Tymoteusz Motylewski commented on patch set 2 06/27/14, 16:31
Lets not remove sys_note and sys_action for now. I will prepare an additional patch which will move the icons from skin to the extension folder. -
Mr. Jenkins commented on patch set 2 06/27/14, 16:43
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/17066/ : SUCCESS -
Anja Leichsenring voted on patch set 2 CR +1 V +1 07/24/14, 15:39
-
Susi Moog voted on patch set 2 CR +1 V +1 07/24/14, 16:12
-
Christian Kuhn voted on patch set 2 CR +2 V +2 07/24/14, 16:13
-
Christian Kuhn merged patch set 2 07/24/14, 16:13