Review main Merged

31040[TASK] Remove old and unused extension icons from t3skin

Tymoteusz Motylewski CR +2 V +2 Easy +0 −0 updated 07/24/14, 16:13

Commit message

in t3skin/icons/ext there are plenty of really old icons
for e.g. tt_guest or tt_calender

We should remove them as they are not used.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Susi Moog +1

Issues 1

Files 27

Show 7 more files

Review log 13

  1. Mr. Jenkins commented on patch set 1 06/22/14, 10:46

  2. Krzysztof Adamczyk voted on patch set 1 V +1 CR +1 06/22/14, 17:10

  3. Krzysztof Adamczyk voted on patch set 1 V 0 06/22/14, 17:19

  4. Krzysztof Adamczyk commented on patch set 1 06/22/14, 17:20

    Tymek, I'm not sure you did anything. You should also create new package with t3 images
  5. Krzysztof Adamczyk commented on patch set 1 06/22/14, 17:28

    small update . instead of anything should be everything
  6. Jigal van Hemert commented on patch set 1 V -1 CR -1 06/22/14, 18:42

    The first file I checked (icon-note.png) is still in use in typo3/sysext/sys_note/Configuration/TCA/sys_note.php . I haven't checked if anything outside the core relies on these icons, but it seems hardly worth the hassle of removing them.
  7. Tymoteusz Motylewski uploaded patch set 2 06/27/14, 16:29

  8. Tymoteusz Motylewski commented on patch set 2 06/27/14, 16:31

    Lets not remove sys_note and sys_action for now. I will prepare an additional patch which will move the icons from skin to the extension folder.
  9. Mr. Jenkins commented on patch set 2 06/27/14, 16:43

  10. Anja Leichsenring voted on patch set 2 CR +1 V +1 07/24/14, 15:39

  11. Susi Moog voted on patch set 2 CR +1 V +1 07/24/14, 16:12

  12. Christian Kuhn voted on patch set 2 CR +2 V +2 07/24/14, 16:13

  13. Christian Kuhn merged patch set 2 07/24/14, 16:13