31083[TASK] Add a "save and close" button in the extensionmanager
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Anja Leichsenring +1
-
Verified V +2
- Christian Kuhn +2
- Anja Leichsenring +1
Issues 1
Files 5
- typo3/sysext/extensionmanager/Classes/Controller/ConfigurationController.php+36 −11
- typo3/sysext/extensionmanager/Resources/Private/Language/locallang.xlf1+0 −3
- typo3/sysext/extensionmanager/Resources/Private/Templates/Configuration/ShowConfigurationForm.html+2 −1
- typo3/sysext/extensionmanager/Resources/Public/JavaScript/configuration.js+3 −0
- typo3/sysext/extensionmanager/ext_tables.php+1 −1
Review log 19
-
Mr. Jenkins commented on patch set 1 06/23/14, 16:34
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/17024/ : SUCCESS -
Anja Leichsenring voted on patch set 1 CR +1 V +1 07/24/14, 09:31
-
Marcin Sągol voted on patch set 1 CR +1 07/24/14, 10:13
-
Christian Kuhn updated the commit message in patch set 2 07/24/14, 10:21
-
Anja Leichsenring voted on patch set 2 CR +1 V +1 07/24/14, 10:23
-
Christian Kuhn commented on patch set 2 CR -1 07/24/14, 10:32
Thanks! +1 for the idea, but the implementation could be improved, there should be a dedicated controller action for this ... susi will work on this issue now. -
Susi Moog uploaded patch set 3 07/24/14, 12:37
-
Anja Leichsenring voted on patch set 3 CR +1 V +1 07/24/14, 12:48
-
Christian Kuhn commented on patch set 3 07/24/14, 13:16
locallang.xlf:67this is usually "Save and close" and should be available as standard label. -
Christian Kuhn commented on patch set 3 CR -1 07/24/14, 13:32
working on it. -
Christian Kuhn uploaded patch set 4 07/24/14, 13:41
-
Christian Kuhn voted on patch set 4 CR -1 07/24/14, 13:41
-
Christian Kuhn uploaded patch set 5 07/24/14, 14:05
-
Christian Kuhn uploaded patch set 6 07/24/14, 14:08
-
Christian Kuhn commented on patch set 6 CR +1 V +1 07/24/14, 14:11
Ok, still could be a little bit nicer since the form submit POST action now overwrites the GET param with the JS ... additionally, using the css class of the icon is not perfect. Still, the patch works and is straight forward. Fine with me. -
Anja Leichsenring voted on patch set 6 CR +1 V +1 07/24/14, 14:30
-
Christian Kuhn voted on patch set 6 CR +2 V +2 07/24/14, 15:11
-
Christian Kuhn merged patch set 6 07/24/14, 15:16
-
Christian Kuhn commented on patch set 7 07/24/14, 15:17
Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 959971dbea4edb24b54a9830673ced88f38b3655