Review main Merged

31169[BUGFIX] Empty class selector crashes Update image

Francois Suter CR +2 V +2 Easy +4 −1 updated 07/05/14, 14:03

Commit message

Prevent the Update image dialog box to crash when trying to access
an empty class selector.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1

Issues 1

Files 1

Review log 5

  1. Markus Klein commented on patch set 1 V +1 CR +1 06/27/14, 13:47

    no-brainer
  2. Mr. Jenkins commented on patch set 1 06/27/14, 13:57

  3. Wouter Wolters commented on patch set 1 V +2 CR +2 07/05/14, 14:03

    Tested with: RTE.default { classesImage = floatleft classesCharacter = floatleft } RTE.classes { floatleft.name = Image left floatleft.value = float:left; }
  4. Wouter Wolters merged patch set 2 07/05/14, 14:03

  5. Wouter Wolters commented on patch set 2 07/05/14, 14:03

    Cherry Picked This patchset was cherry picked to change: Ida2c3dfb185064071fcdcda158f64e330562aa01