Review main Merged

31175[BUGFIX] Prevent spaces in BE shortcut to be replaced by + char

Frans Saris CR +2 V +2 Easy +3 −4 updated 07/01/14, 20:11

Commit message

Due to some changes in Prototype.js the serialized form values
get wrongly escaped with the result that all spaces are replaced
by + chars.

This patch changes the used serialization of the form so the value
is correctly posted.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
    • Krzysztof Adamczyk +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1

Issues 1

Files 1

Review log 13

  1. Frans Saris commented on patch set 1 06/27/14, 19:54

    Changed code is called on: typo3/contrib/scriptaculous/controls.js line 626
  2. Mr. Jenkins commented on patch set 1 06/27/14, 20:03

  3. Krzysztof Adamczyk commented on patch set 1 06/27/14, 20:30

    I can't reproduce this bug
  4. Frans Saris commented on patch set 1 06/27/14, 20:39

    Create a shortcut and change the name (maybe even change type so there is definitly something changed). Just pressing save doesn't update the record. Ik tested in chromium
  5. Markus Klein updated the commit message in patch set 1 06/28/14, 10:58

  6. Markus Klein commented on patch set 2 06/28/14, 11:00

    shortcutmenu.js:71

    Wherever this is used, does it accept an array too?
  7. Frans Saris commented on patch set 2 06/28/14, 11:05

    shortcutmenu.js:71 Reply

    Yes, changed code is called on: typo3/contrib/scriptaculous/controls.js line 626 There the return value is changed to an object when it is a string
  8. Mr. Jenkins commented on patch set 2 06/28/14, 11:14

  9. Markus Klein voted on patch set 2 V +1 CR +1 06/28/14, 11:35

  10. Krzysztof Adamczyk voted on patch set 2 CR +1 06/28/14, 11:41

  11. Wouter Wolters voted on patch set 2 V +2 CR +2 07/01/14, 20:11

  12. Wouter Wolters merged patch set 3 07/01/14, 20:11

  13. Wouter Wolters commented on patch set 3 07/01/14, 20:11

    Cherry Picked This patchset was cherry picked to change: I65d89ab741ae77f5bbef9421923b3878f2295570