31175[BUGFIX] Prevent spaces in BE shortcut to be replaced by + char
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Markus Klein +1
- Krzysztof Adamczyk +1
-
Verified V +2
- Wouter Wolters +2
- Markus Klein +1
Issues 1
Files 1
Review log 13
-
Frans Saris commented on patch set 1 06/27/14, 19:54
Changed code is called on: typo3/contrib/scriptaculous/controls.js line 626 -
Mr. Jenkins commented on patch set 1 06/27/14, 20:03
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/17069/ : SUCCESS -
Krzysztof Adamczyk commented on patch set 1 06/27/14, 20:30
I can't reproduce this bug -
Frans Saris commented on patch set 1 06/27/14, 20:39
Create a shortcut and change the name (maybe even change type so there is definitly something changed). Just pressing save doesn't update the record. Ik tested in chromium -
Markus Klein updated the commit message in patch set 1 06/28/14, 10:58
-
Markus Klein commented on patch set 2 06/28/14, 11:00
shortcutmenu.js:71Wherever this is used, does it accept an array too? -
Frans Saris commented on patch set 2 06/28/14, 11:05
shortcutmenu.js:71ReplyYes, changed code is called on: typo3/contrib/scriptaculous/controls.js line 626 There the return value is changed to an object when it is a string -
Mr. Jenkins commented on patch set 2 06/28/14, 11:14
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/17071/ : SUCCESS -
Markus Klein voted on patch set 2 V +1 CR +1 06/28/14, 11:35
-
Krzysztof Adamczyk voted on patch set 2 CR +1 06/28/14, 11:41
-
Wouter Wolters voted on patch set 2 V +2 CR +2 07/01/14, 20:11
-
Wouter Wolters merged patch set 3 07/01/14, 20:11
-
Wouter Wolters commented on patch set 3 07/01/14, 20:11
Cherry Picked This patchset was cherry picked to change: I65d89ab741ae77f5bbef9421923b3878f2295570