Review TYPO3_6-1 Merged

31215[TASK] Reset phpunit to 3.7 version

Anja Leichsenring CR +2 V +2 Easy +1 −1 updated 06/29/14, 12:16

Commit message

Some 6.1 tests do not work with phpunit 4.0 and above.
Instead of fixing them in 6.1 branch, we use a ext:phpunit
version that bundles phpunit 3.7.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
  • Verified V +2
    • Helmut Hummel +2
    • Anja Leichsenring +1
    • Christian Kuhn +1

Issues 1

Files 1

Review log 11

  1. Christian Kuhn updated the commit message in patch set 1 06/29/14, 09:59

  2. Anja Leichsenring uploaded patch set 3 06/29/14, 10:06

  3. Helmut Hummel commented on patch set 2 06/29/14, 10:08

    .travis.yml:27

    isn't there a branch in phpunit ext which we could checkout directly? if there is none, couldn't we just create it? On the other hand, I would also be fine with adding an additional line here, it is just that the sha1 isn't speaking for itself ;)
  4. Helmut Hummel commented on patch set 3 06/29/14, 10:09

    .travis.yml:28

    see comment on patch set 2 :-)
  5. Anja Leichsenring commented on patch set 3 06/29/14, 10:20

    @Helmut: saw it while pushing the changeset. There is no branch we could use, but we work on it.
  6. Christian Kuhn commented on patch set 3 CR -1 06/29/14, 10:56

    .travis.yml:28 Reply

    Ok, Oliver will create a branch.
  7. Christian Kuhn uploaded patch set 4 06/29/14, 12:11

  8. Christian Kuhn voted on patch set 4 V +1 CR +1 06/29/14, 12:11

  9. Anja Leichsenring voted on patch set 4 V +1 CR +1 06/29/14, 12:12

  10. Helmut Hummel voted on patch set 4 V +2 CR +2 06/29/14, 12:12

  11. Helmut Hummel merged patch set 5 06/29/14, 12:16