Review main Merged

31216[BUGFIX] Create required directories in test bootstrap

Sebastian Bergmann CR +2 V +2 Easy +25 −2 updated 06/29/14, 12:03

Commit message

When running the core unit tests without setting up TYPO3
using the normal installation procedure then the uploads,
typo3temp, and typo3conf/ext directories do not exist.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 2

Review log 25

  1. Christian Kuhn commented on patch set 1 CR -1 06/29/14, 10:31

    Thanks for your patch Sebastian :) I would prefer not to solve the issue at this point. typo3temp is an important directory the install tool and installation process takes care of. In case of the unit test context, I'd prefer to handle existance / creation of typo3temp in typo3/sysext/core/Build/UnitTestBootstrap.xml. BTW: If this works, the .travis.yml "mkdir" command can be simplified / removed.
  2. Mr. Jenkins commented on patch set 1 06/29/14, 10:36

  3. Sebastian Bergmann uploaded patch set 2 06/29/14, 10:39

  4. Christian Kuhn commented on patch set 2 CR -1 06/29/14, 10:47

    still working on it.
  5. Mr. Jenkins commented on patch set 2 06/29/14, 10:54

  6. Sebastian Bergmann uploaded patch set 3 06/29/14, 10:59

  7. Christian Kuhn commented on patch set 3 06/29/14, 11:00

    Thanks, looks really good. Will test now.
  8. Sebastian Bergmann uploaded patch set 4 06/29/14, 11:08

  9. Christian Kuhn voted on patch set 4 V +1 CR +1 06/29/14, 11:09

  10. Oliver Klee commented on patch set 4 CR -1 06/29/14, 11:12

    UnitTestsBootstrap.php:102

    This method needs some PHPDoc. About the naming: As this method is more than just a wrapper, let's name it without abbreviations, e.g. "createDirectory".

    UnitTestsBootstrap.php:103

    Maybe make this a guard clause?

    UnitTestsBootstrap.php:104

    I think we don't need the @ here.
  11. Oliver Klee commented on patch set 4 06/29/14, 11:12

    UnitTestsBootstrap.php:102

    "protected" keyword missing.
  12. Mr. Jenkins commented on patch set 3 06/29/14, 11:22

  13. Sebastian Bergmann uploaded patch set 5 06/29/14, 11:29

  14. Mr. Jenkins commented on patch set 4 06/29/14, 11:30

  15. Sebastian Bergmann uploaded patch set 6 06/29/14, 11:31

  16. Oliver Klee voted on patch set 6 CR +1 06/29/14, 11:31

  17. Sebastian Bergmann uploaded patch set 7 06/29/14, 11:34

  18. Christian Kuhn voted on patch set 7 V +1 CR +1 06/29/14, 11:42

  19. Oliver Klee voted on patch set 7 CR +1 06/29/14, 11:42

  20. Mr. Jenkins commented on patch set 5 06/29/14, 11:43

  21. Christian Kuhn voted on patch set 7 V +2 CR +2 06/29/14, 11:44

  22. Christian Kuhn merged patch set 8 06/29/14, 11:44

  23. Mr. Jenkins commented on patch set 6 06/29/14, 11:47

  24. Mr. Jenkins commented on patch set 7 06/29/14, 11:57

  25. Christian Kuhn commented on patch set 8 06/29/14, 12:03

    Cherry Picked This patchset was cherry picked to change: Ib6b8ecd480b83cf818f54d865a4ff61fe62d2893