Review TYPO3_6-2 Merged

31237Revert "[TASK] Rebuild the calcAge functionality"

Christian Kuhn CR +2 V +2 Expert +216 −1043 updated 06/29/14, 21:40

Commit message

This change was considered to need some more work during
merge post review:
* 6.2 version adds not allowed deprecations to a released branch
* It adds two arbitrary (public) constants CEIL and FLOOR
* Method names need improvement
* Violation of single responsibility
* The static utility class has dependencies
* The patch adds another "always loaded" file to main bootstrap
* Undocumented (minor) breaking changes
* (Minor) code style issues

Reverted: #20016
Releases: 6.3, 6.2

This reverts commit 4c52cb3cfe4f6819a29f1daa064859affe23989d
Change-Id: I6dff8aaa8bf8cfdb80cca56c9c967f2a2ea6fb52
Reviewed-on: https://review.typo3.org/31237
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Files 25

Show 5 more files

Review log 5

  1. Christian Kuhn updated the commit message in patch set 1 06/29/14, 21:39

  2. Christian Kuhn voted on patch set 2 V +2 CR +2 06/29/14, 21:39

  3. Helmut Hummel updated the commit message in patch set 2 06/29/14, 21:39

  4. Christian Kuhn voted on patch set 3 V +2 CR +2 06/29/14, 21:39

  5. Christian Kuhn merged patch set 5 06/29/14, 21:40