Review main Merged

31238[FEATURE] Introduce afterPersistObjetct signal slot

Nico de Haen CR +2 V +2 Easy +10 −0 updated 07/01/14, 19:07

Commit message

At the moment we only have an afterUpdate signal which
is emitted when an object is updated. But we don't have
a signal which is emitted after persisting an existing
aggregate root, if only sub objects or object storages
belonging to the aggregate root are updated.

Since the aggregate root should "encapsulate" the contained
objects to the outer world, we should provide such a signal,
which is fired if all objects of an aggregate root are persisted.

The same signal is emitted in the persistObject method in
the AbstractBackend class in Flow.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Anja Leichsenring +1
  • Verified V +2
    • Wouter Wolters +2
    • Anja Leichsenring +1

Issues 1

Files 1

Review log 11

  1. Mr. Jenkins commented on patch set 1 06/29/14, 22:28

  2. Anja Leichsenring commented on patch set 1 06/30/14, 06:07

    Hi Nico, same here. Please explain what you do and why.
  3. Nico de Haen updated the commit message in patch set 1 06/30/14, 07:26

  4. Wouter Wolters updated the commit message in patch set 2 06/30/14, 07:29

  5. Nico de Haen commented on patch set 2 06/30/14, 07:29

    The forge ticket has an example extension attached to compare the effect of the different signals
  6. Wouter Wolters commented on patch set 3 06/30/14, 07:30

    I shortened the line length otherwise Jenkins is not so happy;)
  7. Mr. Jenkins commented on patch set 2 CR -1 V -1 06/30/14, 07:42

  8. Mr. Jenkins commented on patch set 3 06/30/14, 07:44

  9. Anja Leichsenring commented on patch set 3 V +1 CR +1 06/30/14, 09:06

    thanks for explanation
  10. Wouter Wolters voted on patch set 3 V +2 CR +2 07/01/14, 19:07

  11. Wouter Wolters merged patch set 4 07/01/14, 19:07