Review main Merged

31240[BUGFIX] Use correct array structure for EM error messages

Sascha Egerer CR +2 V +2 Normal +63 −2 updated 07/01/14, 17:19

Commit message

The extension manager stores errors (like exceptions that
are thrown while installing an extension) in an array and
passes them to a fluid template.

The array has to be in a defined structure like
$errorMessages[extension name][i] = array(
»       error code,
»       error message
)

Currently, if an extension is installed from ter and an error occurs
while downloading the extension, the code and text are stored directly
under the extension name and therefore the array is not correctly parsed
by the fluid template.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Nicole Hummel +2
  • Verified V +2
    • Wouter Wolters +2
    • Nicole Hummel +2

Issues 1

Files 2

Review log 13

  1. Mr. Jenkins commented on patch set 1 06/30/14, 09:48

  2. Nicole Hummel updated the commit message in patch set 1 07/01/14, 14:33

  3. Nicole Hummel voted on patch set 2 V +2 CR +2 07/01/14, 14:34

  4. Mr. Jenkins commented on patch set 2 07/01/14, 14:48

  5. Nicole Hummel uploaded patch set 3 07/01/14, 14:55

  6. Nicole Hummel commented on patch set 3 V +2 CR +2 07/01/14, 14:57

    Added dependency to other patch
  7. Nicole Hummel uploaded patch set 4 07/01/14, 15:01

  8. Nicole Hummel commented on patch set 4 V +2 CR +2 07/01/14, 15:02

    Now with dependency and correct commit message
  9. Mr. Jenkins commented on patch set 3 07/01/14, 15:11

  10. Mr. Jenkins commented on patch set 4 07/01/14, 15:26

  11. Wouter Wolters voted on patch set 4 V +2 CR +2 07/01/14, 17:18

  12. Wouter Wolters merged patch set 5 07/01/14, 17:18

  13. Wouter Wolters commented on patch set 5 07/01/14, 17:19

    Cherry Picked This patchset was cherry picked to change: Id330f0af2a99ab99cb8b736332cb8506c857716c