Review TYPO3_6-1 Merged

31284[BUGFIX] Create workspace label placeholder that matches field conditions

Sascha Egerer CR +2 V +2 Normal +73 −1 updated 07/02/14, 11:20

Commit message

If a workspace placeholder record is generated the field, that
is configured as label for a table, is filled with a placeholder.
This is a hardcoded string.
If database field does not allow strings (integer, double...)
a TYPO3 warning is displayed. "... Propably value mismatch ...".
This message is very confusing because the user does not know
where it comes from.

The label should be evaluated against the TCA eval configuration
before it is written to the database.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Sascha Egerer +1
  • Verified V +2
    • Oliver Hader +2
    • Sascha Egerer +1

Issues 1

Files 2

Review log 4

  1. Sascha Egerer commented on patch set 1 V +1 CR +1 07/02/14, 08:35

    Fixed merge conflicts in DataHandlerTest.
  2. Oliver Hader voted on patch set 1 CR +1 07/02/14, 11:19

  3. Oliver Hader voted on patch set 1 V +2 CR +2 07/02/14, 11:20

  4. Oliver Hader merged patch set 2 07/02/14, 11:20