Review main Merged

31321[CLEANUP] Stupid array assignment

Sascha Egerer CR +2 V +2 Easy +2 −2 updated 07/04/14, 15:25

Commit message

There are two places where a new item is assigned
to an array with `$myArray[] .= ''`.
This would do the same as `$myArray[] = ''` because
it always adds a new item to the array.

Review

  • Code review CR +2
    • Nicole Hummel +2
    • Markus Klein +1
  • Verified V +2
    • Nicole Hummel +2
    • Markus Klein +1

Issues 1

Files 1

Review log 10

  1. Mr. Jenkins commented on patch set 1 07/04/14, 12:58

  2. Markus Klein voted on patch set 1 V +1 CR +1 07/04/14, 13:30

  3. Sascha Egerer updated the commit message in patch set 1 07/04/14, 13:56

  4. Markus Klein voted on patch set 2 V +1 CR +1 07/04/14, 14:04

  5. Nicole Hummel voted on patch set 2 V +2 CR +2 07/04/14, 14:10

  6. Nicole Hummel merged patch set 4 07/04/14, 14:10

  7. Mr. Jenkins commented on patch set 2 07/04/14, 14:10

  8. Anja Leichsenring commented on patch set 4 07/04/14, 14:34

    hey guys, I value your constant effort to clean up code, but would you mind to be a little bit more selective with your wording? Maybe the assignment is not very wise, but this message went out now via Twitter, it is readable in history an d changelog. Is this really the way we want to treat our contributors?
  9. Markus Klein commented on patch set 4 07/04/14, 15:01

    Anja, you're of course right. I'm sorry I didn't say anything against this wording. My apologies to Martin Kutschker and Steffen Kamper, who added this code back in May 2008. >> SHA-1: d21897d0c97291d208eed310fabc26e37995e2f9 * Fixed bug #8418: visual problems of BE[accessListRenderMode] (thanx to Steffen Kamper) git-svn-id: https://svn.typo3.org/TYPO3v4/Core/trunk@3729 709f56b5-9817-0410-a4d7-c38de5d9e867 >>
  10. Sascha Egerer commented on patch set 4 07/04/14, 15:25

    I'm Sorry for the wording. Was not aware that it was underdstood like you Understand it