31329[BUGFIX] Prevent uninstall of an extension during update
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Markus Klein +1
- Wouter Wolters +1
- Stefano Kowalke +1
-
Verified V +2
- Christian Kuhn +2
- Markus Klein +1
Issues 1
Files 1
Review log 9
-
Stefano Kowalke voted on patch set 1 CR +1 07/04/14, 21:24
-
Wouter Wolters voted on patch set 1 CR +1 07/05/14, 11:41
-
Markus Klein voted on patch set 1 CR +1 V +1 08/01/14, 12:43
-
Christian Kuhn commented on patch set 1 CR -1 08/13/14, 19:11
Mmmmh, I'm not really sure on possible side effects of this patch. The installation process does quite some stuff and this uninstall/reinstall procedure was there for a reason. If we remove it to fix a "load order" issue in 6.1, we may easily introduce new issues. Since 6.1 is old-stable already, I tend to not take this risk and would live with the load order issue for now, until someone comes up with a good explanation on why the patch is harmless. -
Nicole Hummel commented on patch set 1 08/13/14, 19:19
The patch has to be harmless as we already removed the same situation for 6.2 before! -
Christian Kuhn commented on patch set 1 08/13/14, 19:25
https://forge.typo3.org/issues/57264 https://review.typo3.org/#/c/28883/ ... So a very similar patch was done in 6.2 already ... Added the relations and the review of this now. -
Christian Kuhn voted on patch set 1 CR 0 08/13/14, 19:25
-
Christian Kuhn voted on patch set 1 CR +2 V +2 08/13/14, 19:27
-
Christian Kuhn merged patch set 1 08/13/14, 19:28