Review main Merged

31330[BUGFIX] Extensionmanager: Dependency errors are not reset

Nicole Hummel CR +2 V +2 Easy +1 −0 updated 07/06/14, 11:53

Commit message

Due to changes in https://review.typo3.org/#/c/29845/ dependency errors
are collected and if one error occurred it is returned for every check
regardless of the key. This patch adds a reset for the error array on
every new dependency check.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Marcin Sągol +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1

Issues 1

Files 1

Review log 9

  1. Mr. Jenkins commented on patch set 1 07/04/14, 23:05

  2. Oliver Klee voted on patch set 1 CR +1 07/05/14, 08:25

  3. Marcin Sągol voted on patch set 1 CR +1 07/05/14, 10:49

  4. Wouter Wolters commented on patch set 1 CR +1 07/05/14, 11:26

    Any easy way to verify this step by step?
  5. Wouter Wolters commented on patch set 1 V +1 07/05/14, 11:36

    Found it. Installing an extension returned everytime in the same screen about dependency error
  6. Christian Kuhn commented on patch set 1 V +1 CR +1 07/06/14, 11:13

    +1, should solve the issue for now. Looking at this "utility" (it is not a stateless utility!), this class should probably not implement singletonInterface, then those state issues would vanish?!
  7. Christian Kuhn voted on patch set 1 V +2 CR +2 07/06/14, 11:14

  8. Christian Kuhn merged patch set 2 07/06/14, 11:14

  9. Christian Kuhn commented on patch set 2 07/06/14, 11:53

    Cherry Picked This patchset was cherry picked to change: Id734ba1fe8981ffd270d79d4971ac9de9b72b4b4