Review main Merged

31489[TASK] Update phpdoc @return of exec_SELECTgetSingleRow()

Markus Klein CR +2 V +2 Easy +1 −1 updated 07/08/14, 08:27

Commit message

DatabaseConnection::exec_SELECTgetSingleRow() may return FALSE if no row
is found. This is not reflected in the phpdoc for the return value.

This patch adds the necessary information to the doc header.

Review

  • Code review CR +2
    • Markus Klein +2
    • Sascha Egerer +1
    • Wouter Wolters +1
    • Marcin Sągol +1
    • Thomas Löffler +1
  • Verified V +2
    • Markus Klein +2
    • Wouter Wolters +1
    • Marcin Sągol +1

Issues 1

Files 1

Review log 8

  1. Thomas Löffler voted on patch set 1 CR +1 07/08/14, 08:17

  2. Wouter Wolters voted on patch set 1 V +1 CR +1 07/08/14, 08:17

  3. Sascha Egerer voted on patch set 1 CR +1 07/08/14, 08:19

  4. Marcin Sągol voted on patch set 1 V +1 CR +1 07/08/14, 08:19

  5. Markus Klein voted on patch set 1 V +2 CR +2 07/08/14, 08:21

  6. Markus Klein merged patch set 2 07/08/14, 08:21

  7. Markus Klein commented on patch set 2 07/08/14, 08:21

    Cherry Picked This patchset was cherry picked to change: Ia07868c2a1e8fad5b1d53d89ff0a959c2bcf9e3a
  8. Mr. Jenkins commented on patch set 1 07/08/14, 08:27