Review main Merged

31524[BUGFIX] Collapse icon for accordion not centered in Install Tool

Wouter Wolters CR +2 V +2 Easy +1 −2 updated 07/09/14, 09:30

Commit message

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Sascha Egerer +1
    • Markus Klein +1
  • Verified V +2
    • Wouter Wolters +2
    • Sascha Egerer +1
    • Markus Klein +1

Issues 1

Files 1

Review log 9

  1. Mr. Jenkins commented on patch set 1 07/08/14, 21:39

  2. Markus Klein commented on patch set 1 CR +1 07/08/14, 21:54

    Install.css:473

    This works in IE, so maybe we should keep it?
  3. Wouter Wolters commented on patch set 1 07/08/14, 21:58

    Install.css:473 Reply

    the other solution also works in IE7 and highe. These are CSS3 properties which do not work for some reason and IE is not supporting all of these in the older browsers.
  4. Markus Klein voted on patch set 1 V +1 07/09/14, 08:26

  5. Markus Klein commented on patch set 1 07/09/14, 08:27

    Install.css:473 Reply

    AFAIK the -y and -x never made it into the standard!
  6. Sascha Egerer voted on patch set 1 V +1 CR +1 07/09/14, 08:29

  7. Wouter Wolters voted on patch set 1 V +2 CR +2 07/09/14, 09:29

  8. Wouter Wolters merged patch set 2 07/09/14, 09:30

  9. Wouter Wolters commented on patch set 2 07/09/14, 09:30

    Cherry Picked This patchset was cherry picked to change: I4bacce041ca3be3dce4cae1a7407ab3fdf301ff0