Review main Merged

31571[BUGFIX] sys_collection_entries column too small

Wouter Wolters CR +2 V +2 Easy +1 −1 updated 07/20/14, 21:20

Commit message

Set sys_collection_entries to varchar(64). This is the max
table name length on MySQL.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Oliver Klee +1
    • Markus Klein +1
    • Ernesto Baschny +1
  • Verified V +2
    • Stefan Neufeind +2
    • Markus Klein +1

Issues 1

Files 1

Review log 16

  1. Mr. Jenkins commented on patch set 1 07/10/14, 18:53

  2. Markus Klein commented on patch set 1 07/10/14, 18:54

    on mysql... but not on others
    whom do we need to ask for 6.2 permission?
  3. Markus Klein voted on patch set 1 CR +1 07/10/14, 18:54

  4. Wouter Wolters commented on patch set 1 07/11/14, 10:57

    Reply

    Should we change the commit message then?

    Reply

    IMO this change isn't if you don't have any trouble. People who are having trouble can update their database. I see this as a non breaking change.
  5. Markus Klein commented on patch set 1 07/11/14, 11:05

    Reply

    Will do

    Reply

    Me too, but usually the team was very very strict about DB changes. I'd opt for changing this rule, such that we do allow changes like this.
  6. Markus Klein updated the commit message in patch set 1 07/11/14, 11:06

  7. Markus Klein voted on patch set 2 CR +1 07/11/14, 11:06

  8. Markus Klein voted on patch set 2 V +1 07/11/14, 11:06

  9. Mr. Jenkins commented on patch set 2 07/11/14, 11:36

  10. Stefan Neufeind commented on patch set 2 CR +1 07/13/14, 20:12

    I agree that the change might be "okay" since updating the DB is optional here (nothing breaks/fails if you don't). But I also thought about the stricktness in the past regarding DB-changes (for 6.2). Personally I'm fine with the change.
  11. Stefan Neufeind commented on patch set 2 07/18/14, 22:44

    Let's wait for Ernesto regarding 6.2. I just emailed him.
  12. Oliver Klee voted on patch set 2 CR +1 07/20/14, 17:33

  13. Ernesto Baschny commented on patch set 2 CR +1 07/20/14, 21:13

    Good catch, go ahead
  14. Stefan Neufeind commented on patch set 2 CR +2 V +2 07/20/14, 21:20

    Let's have it in.
  15. Stefan Neufeind merged patch set 2 07/20/14, 21:20

  16. Stefan Neufeind commented on patch set 3 07/20/14, 21:20

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 96ce4beee70a01908ece732cfae1f0e606cd1a42