Review main Merged

3158[BUGFIX] Unit tests for dbbackend throw db errors

Philipp Gampe CR +2 V +2 Easy +2 −2 updated 06/03/13, 20:49

Commit message

When running the unit test for t3lib_cache_backend_dbbackend
eight sql errors are thrown. This could happen if TYPO3_DB is
mocked.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Philipp Gampe +1
  • Verified V +2
    • Christian Kuhn +2
    • Philipp Gampe +1

Issues 1

Files 1

Review log 16

  1. Christian Kuhn uploaded patch set 2 07/08/11, 20:17

  2. Christian Kuhn commented on patch set 3 V 0 07/08/11, 20:17

    by team member; Looks good to me, approved Thanks Philipp! I'll just merge this as a nearly no-brainer now.
  3. Christian Kuhn commented on patch set 3 07/08/11, 20:17

    @Philipp: This shouldn't happen, there is already a 'drop table if exists' in tearDown(). I think this can only happen if tearDown() still runs on a mocked TYPO3_DB, so I now moved the reconstruction of the original TYPO3_DB before the table drop call. Does this fix the problem for you?
  4. Christian Kuhn uploaded patch set 3 07/08/11, 20:17

  5. Philipp Gampe commented on patch set 3 07/08/11, 20:17

    Verified; Looks good to me, but someone else must approve Yes this fixes it for me
  6. Mr. Jenkins commented on patch set 1 07/08/11, 20:17

  7. Mr. Jenkins commented on patch set 1 07/08/11, 20:17

  8. Mr. Jenkins commented on patch set 1 07/08/11, 20:17

    Fails; I would prefer that you didn't submit this Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/972/ : FAILURE
  9. Mr. Jenkins commented on patch set 1 07/08/11, 20:17

    No score; No score Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/981/ : SUCCESS
  10. Mr. Jenkins commented on patch set 1 07/08/11, 20:17

  11. Mr. Jenkins commented on patch set 1 07/08/11, 20:17

  12. Mr. Jenkins commented on patch set 1 07/08/11, 20:17

  13. Mr. Jenkins commented on patch set 1 07/08/11, 20:17

  14. Mr. Jenkins commented on patch set 2 07/08/11, 20:17

  15. Mr. Jenkins commented on patch set 3 07/08/11, 20:17

  16. Christian Kuhn merged patch set 3 07/08/11, 20:17