3158[BUGFIX] Unit tests for dbbackend throw db errors
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Philipp Gampe +1
-
Verified V +2
- Christian Kuhn +2
- Philipp Gampe +1
Issues 1
Files 1
Review log 16
-
Christian Kuhn uploaded patch set 2 07/08/11, 20:17
-
Christian Kuhn commented on patch set 3 V 0 07/08/11, 20:17
by team member; Looks good to me, approved Thanks Philipp! I'll just merge this as a nearly no-brainer now. -
Christian Kuhn commented on patch set 3 07/08/11, 20:17
@Philipp: This shouldn't happen, there is already a 'drop table if exists' in tearDown(). I think this can only happen if tearDown() still runs on a mocked TYPO3_DB, so I now moved the reconstruction of the original TYPO3_DB before the table drop call. Does this fix the problem for you? -
Christian Kuhn uploaded patch set 3 07/08/11, 20:17
-
Philipp Gampe commented on patch set 3 07/08/11, 20:17
Verified; Looks good to me, but someone else must approve Yes this fixes it for me -
Mr. Jenkins commented on patch set 1 07/08/11, 20:17
Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/980/ : FAILURE -
Mr. Jenkins commented on patch set 1 07/08/11, 20:17
Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/973/ : FAILURE -
Mr. Jenkins commented on patch set 1 07/08/11, 20:17
Fails; I would prefer that you didn't submit this Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/972/ : FAILURE -
Mr. Jenkins commented on patch set 1 07/08/11, 20:17
No score; No score Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/981/ : SUCCESS -
Mr. Jenkins commented on patch set 1 07/08/11, 20:17
Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/979/ : FAILURE -
Mr. Jenkins commented on patch set 1 07/08/11, 20:17
Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/977/ : FAILURE -
Mr. Jenkins commented on patch set 1 07/08/11, 20:17
Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/978/ : FAILURE -
Mr. Jenkins commented on patch set 1 07/08/11, 20:17
Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/974/ : FAILURE -
Mr. Jenkins commented on patch set 2 07/08/11, 20:17
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/983/ : SUCCESS -
Mr. Jenkins commented on patch set 3 07/08/11, 20:17
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/984/ : SUCCESS -
Christian Kuhn merged patch set 3 07/08/11, 20:17