Review main Merged

31641[BUGFIX] Adjust comment for default HTTP-userAgent

Stefan Neufeind CR +2 V +2 Easy +1 −1 updated 07/23/14, 09:42

Commit message

The default userAgent is for example TYPO3/6.2.4

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Oliver Klee +1
    • Markus Klein +1
  • Verified V +2
    • Stefan Neufeind +2
    • Markus Klein +1

Issues 1

Files 1

Review log 8

  1. Stefan Neufeind uploaded patch set 1 07/16/14, 21:15

  2. Stefan Neufeind commented on patch set 1 07/16/14, 21:17

    Did we maybe use TYPO3_branch instead of TYPO3_version in the past, for improved "privacy" or so? But currently TYPO3_version is used - see the default in typo3/sysext/core/Configuration/DefaultConfiguration.php
  3. Markus Klein voted on patch set 1 CR +1 V +1 07/18/14, 13:46

  4. Stefan Neufeind commented on patch set 1 07/20/14, 22:35

    Could somebody please make a decision if we really want to have the full version in there (like this patch now completes) or instead the branch (like it isn't now, but as the comment suggests)?
  5. Oliver Klee voted on patch set 1 CR +1 07/21/14, 11:15

  6. Stefan Neufeind commented on patch set 1 CR +2 V +2 07/23/14, 09:42

    Let's take it as is for now - no change in behaviour (still the full version), but adjust the comment accordingly.
  7. Stefan Neufeind merged patch set 1 07/23/14, 09:42

  8. Stefan Neufeind commented on patch set 2 07/23/14, 09:42

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit f0cd2c3b89c63488b4c2cb98cc13de3f9597dfbc