Review TYPO3_6-2 Merged

31719[BUGFIX] Fix return value of DatabaseConnection::sql_free_result()

Wouter Wolters CR +2 V +2 Easy +2 −1 updated 07/22/14, 11:29

Commit message

In case of success the current implementation returns the result
of $res->free(). Unfortunately free() doesn't return anything.
That causes sql_free_result() to return NULL, which eventually
evaluates to FALSE.

Make sure the return value is correct and
return TRUE in case of success.

Review

  • Code review CR +2
    • Wouter Wolters +2
  • Verified V +2
    • Wouter Wolters +2

Issues 1

Files 1

Review log 2

  1. Wouter Wolters voted on patch set 1 V +2 CR +2 07/22/14, 11:21

  2. Wouter Wolters merged patch set 1 07/22/14, 11:29