31737[BUGFIX] Change sys_file.size type from INT to BIGINT
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Christian Kuhn +1
- Susi Moog +1
-
Verified V +2
- Anja Leichsenring +2
- Christian Kuhn +1
- Susi Moog +1
Issues 1
Files 1
Review log 16
-
Stefan Neufeind uploaded patch set 1 07/23/14, 11:06
-
Stefan Neufeind commented on patch set 1 CR +1 07/23/14, 11:08
Imho low critical to have this for 6.2 as well. No harm if the sql-change is not performed, but increased flexibility if it is :-) We had a similar case of a SQL-schema-update for 6.2 just lately. -
Wouter Wolters voted on patch set 1 CR +1 07/23/14, 11:12
-
Markus Klein commented on patch set 1 CR +1 07/23/14, 14:37
is bigint(20) the max possible? -
Stefan Neufeind commented on patch set 1 07/23/14, 14:56
Largest type and "more than enough". http://dev.mysql.com/doc/refman/5.5/en/integer-types.html I tested to just alter the column to "bigint" and the 20 was what MySQL came up itself when comparing. So I added that as well to tell the install-tool both definitions match. -
Stefan Neufeind commented on patch set 1 07/23/14, 14:57
Well, we could (should?) update it to unsigned maybe. Negative size doesn't make sense. -
David Greiner voted on patch set 1 CR +1 07/24/14, 04:43
-
Christian Kuhn voted on patch set 1 CR +1 07/24/14, 10:41
-
Christian Kuhn commented on patch set 1 CR -1 07/24/14, 12:00
working on it. -
Christian Kuhn uploaded patch set 2 07/24/14, 12:07
-
Christian Kuhn commented on patch set 2 CR +1 V +1 07/24/14, 12:10
added and tested unsigned flag. -
Anja Leichsenring voted on patch set 2 CR +1 V +1 07/24/14, 12:11
-
Susi Moog voted on patch set 2 CR +1 V +1 07/24/14, 12:12
-
Anja Leichsenring voted on patch set 2 CR +2 V +2 07/24/14, 12:12
-
Anja Leichsenring merged patch set 2 07/24/14, 12:12
-
Anja Leichsenring commented on patch set 3 07/24/14, 12:13
Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 85980085a613db18311e111d5d92b26668fd7701