Review main Merged

31743[BUGFIX] Fix resource exceptions

Helmut Hummel CR +2 V +2 Easy +10 −8 updated 07/24/14, 13:17

Commit message

When rendering the FILES content object,
exceptions due to missing file references and missing collections
are meant to be caught. However they are not, because
InvalidArgumentException and RuntimeException are thrown instead of
ResourceDoesNotExistException

Throw the appropriate exceptions instead and also
fix a wrong check in RecordCollection Repository, where
the return type is checked against NULL while the DB
call returns FALSE when no record is found.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Wouter Wolters +1
    • Susi Moog +1
  • Verified V +2
    • Anja Leichsenring +2
    • Susi Moog +1

Issues 1

Files 3

Review log 16

  1. Helmut Hummel uploaded patch set 1 07/23/14, 18:51

  2. Markus Klein updated the commit message in patch set 2 07/23/14, 18:59

  3. Markus Klein voted on patch set 2 CR +1 07/23/14, 18:59

  4. Oliver Hader voted on patch set 2 CR +2 07/23/14, 19:50

  5. Nicole Hummel voted on patch set 2 CR +1 07/23/14, 21:46

  6. Anja Leichsenring voted on patch set 2 CR +1 V +1 07/24/14, 10:34

  7. Wouter Wolters commented on patch set 2 CR +1 07/24/14, 11:42

    ResourceFactory.php:584

    fileusage -> file usage
  8. Anja Leichsenring commented on patch set 2 07/24/14, 12:34

    working on the comment
  9. Anja Leichsenring uploaded patch set 3 07/24/14, 12:35

  10. Anja Leichsenring voted on patch set 3 CR +1 V +1 07/24/14, 12:37

  11. Wouter Wolters voted on patch set 3 CR +1 07/24/14, 12:37

  12. Susi Moog voted on patch set 3 CR +1 V +1 07/24/14, 13:04

  13. Anja Leichsenring voted on patch set 3 CR +2 V +2 07/24/14, 13:08

  14. Anja Leichsenring merged patch set 3 07/24/14, 13:08

  15. Anja Leichsenring commented on patch set 4 07/24/14, 13:08

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit d512d1cab68b8dfcf90fb33da7a18390b9c66633
  16. Christian Kuhn commented on patch set 4 07/24/14, 13:17

    kills a functional test ...