Review main Merged

31744[BUGFIX] Fix call to undefined function when importing t3x

Silvia Bigler CR +2 V +2 Easy +6 −3 updated 08/23/14, 14:50

Commit message

When importing a t3x file that contains files the function
"getFiles" of the object TYPO3\CMS\Core\Resource\Folder is called
which does not exist.

Review

  • Code review CR +2
    • Markus Klein +2
  • Verified V +2
    • Markus Klein +2

Issues 1

Files 1

Review log 15

  1. Silvia Bigler uploaded patch set 1 07/23/14, 22:54

  2. Markus Klein voted on patch set 1 CR +1 07/24/14, 00:26

  3. Wouter Wolters commented on patch set 1 CR -1 07/24/14, 11:47

    ImportExport.php:2183

    use tabs for indentation please.
  4. Sascha Egerer commented on patch set 1 CR -1 07/24/14, 12:08

    I'll fix that whitespace thing
  5. Sascha Egerer uploaded patch set 2 07/24/14, 15:23

  6. Sascha Egerer commented on patch set 1 07/24/14, 15:24

    I've added a test t3x file to the ticket

    ImportExport.php:2183 Reply

    Done
  7. Sascha Egerer uploaded patch set 3 07/24/14, 15:56

  8. John Nielsen commented on patch set 3 08/22/14, 10:07

    Error repeats with importFolder on line 2801 (approximately) Applying previous fix solves the issue.
  9. Markus Klein uploaded patch set 4 08/22/14, 10:26

  10. Markus Klein commented on patch set 4 CR +1 08/22/14, 10:27

    Thanks John for testing. Please vote on the new patch.
  11. John Nielsen voted on patch set 4 CR +1 08/22/14, 10:40

  12. Markus Klein uploaded patch set 5 08/23/14, 14:48

  13. Markus Klein commented on patch set 5 CR +2 V +2 08/23/14, 14:49

    Merging this as no-brainer
  14. Markus Klein merged patch set 5 08/23/14, 14:49

  15. Markus Klein commented on patch set 6 08/23/14, 14:50

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 4abf73f79bdd6fb7168e007ebb3adeefc703c433