Review main Merged

31748[BUGFIX] Turn isOnSymmetricSide into static function

Peter Niederlag CR +2 V +2 Easy +1 −1 updated 07/24/14, 18:33

Commit message

Function isOnSymmetricSide of RelationHandler is used as
static function all the time so we properly turn the function
declaration into a static one.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1

Issues 1

Files 1

Review log 11

  1. Peter Niederlag uploaded patch set 1 07/24/14, 10:24

  2. Anja Leichsenring updated the commit message in patch set 2 07/24/14, 10:29

  3. Wouter Wolters commented on patch set 2 07/24/14, 11:44

    RelationHandler.php:1311

    static public
  4. Peter Niederlag commented on patch set 2 07/24/14, 12:42

    RelationHandler.php:1311 Reply

  5. Markus Klein commented on patch set 2 CR +1 07/24/14, 16:24

    RelationHandler.php:1311 Reply

    What do you mean Peter?
  6. Christian Kuhn uploaded patch set 3 07/24/14, 18:20

  7. Christian Kuhn voted on patch set 3 CR +1 V +1 07/24/14, 18:21

  8. Anja Leichsenring voted on patch set 3 CR +1 V +1 07/24/14, 18:23

  9. Christian Kuhn voted on patch set 3 CR +2 V +2 07/24/14, 18:33

  10. Christian Kuhn merged patch set 3 07/24/14, 18:33

  11. Christian Kuhn commented on patch set 4 07/24/14, 18:33

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 877488dfc38601f0eb8d0f63d88c3f2b53362157