Review TYPO3_6-2 Merged

31757[BUGFIX] Fix resource exceptions

Anja Leichsenring CR +2 V +2 Easy +10 −8 updated 07/24/14, 13:08

Commit message

When rendering the FILES content object,
exceptions due to missing file references and missing collections
are meant to be caught. However they are not, because
InvalidArgumentException and RuntimeException are thrown instead of
ResourceDoesNotExistException

Throw the appropriate exceptions instead and also
fix a wrong check in RecordCollection Repository, where
the return type is checked against NULL while the DB
call returns FALSE when no record is found.

Review

  • Code review CR +2
    • Anja Leichsenring +2
  • Verified V +2
    • Anja Leichsenring +2

Issues 1

Files 3

Review log 2

  1. Anja Leichsenring voted on patch set 1 CR +2 V +2 07/24/14, 13:08

  2. Anja Leichsenring merged patch set 1 07/24/14, 13:08