31758[TASK] Consolidate JSimgCode in TSFE into additionalJavaScript
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Nicole Hummel +1
-
Verified V +2
- Christian Kuhn +2
Issues 1
Files 2
Review log 18
-
Benni Mack uploaded patch set 1 07/24/14, 13:29
-
Benni Mack uploaded patch set 2 09/08/14, 11:31
-
Stefan Froemken commented on patch set 2 CR +1 09/08/14, 13:17
This was a public property so maybe it could be used by some extension authors. So I don't know if it was good to delete this implementation directly without deprecation annotation. -
Christian Kuhn commented on patch set 2 CR +1 V +1 09/09/14, 10:34
Regarding the public question in this case: There are API's to push JS code into FE. If someone circumvents this in his code and uses a public property just because it is there ... hmmm, yeah then it breaks. OTOH I think this risk is pretty low in this case, so I'd opt for dropping the property here. -
Fabien Udriot voted on patch set 2 CR +1 09/09/14, 11:11
-
Alexander Opitz commented on patch set 2 V +1 CR +1 09/09/14, 11:18
Fine with me, the visibility was defined as TODO so nobody should depend on it. -
Nicole Hummel commented on patch set 2 CR -1 09/09/14, 11:24
GraphicalMenuContentObject.php:415Shouldn't this be initiated anywhere? GraphicalMenu should be mentioned as reserved key for $additionalJavaScriptTypoScriptFrontendController.php:468As this is a public feature, shouldn't we deprecate it and add a fallback to additionalJavaScript -
Christian Kuhn commented on patch set 2 CR -1 09/09/14, 13:51
will push updateGraphicalMenuContentObject.php:415Replymmmh ... then lets re-use JSimgCode again ...TypoScriptFrontendController.php:468ReplySee my previous answer: I think drop is ok in this specific case. -
Christian Kuhn uploaded patch set 3 09/09/14, 13:53
-
Christian Kuhn voted on patch set 3 CR +1 V +1 09/09/14, 13:55
-
Christian Kuhn uploaded patch set 4 09/09/14, 14:21
-
Nicole Hummel voted on patch set 4 CR +1 09/09/14, 14:27
-
Christian Kuhn voted on patch set 4 CR +1 V +1 09/09/14, 14:30
-
Christian Kuhn voted on patch set 4 CR +2 V +2 09/09/14, 14:44
-
Christian Kuhn merged patch set 4 09/09/14, 14:44
-
Helmut Hummel commented on patch set 5 09/12/14, 08:45
Will merge the followup: http://review.typo3.org/32736TypoScriptFrontendController.php:468This is still used in PageGenerator.php -
Helmut Hummel commented on patch set 5 09/12/14, 08:48
btw. this patch removed a public property. do we need to document this as breaking change? I'd say, no as it was marked as "reserved" -
Helmut Hummel commented on patch set 5 09/12/14, 08:49
on the other hand, the commit message does not even have a !!! We should do so in future commits…