3178[FEATURE] Rounding functionality in stdWrap
Commit message
Review
-
Code review CR +2
- Andreas Wolf +2
-
Verified V +2
- Andreas Wolf +2
Issues 1
Files 2
Review log 37
Show 12 earlier messages
-
Andreas Wolf merged patch set 1 07/11/11, 17:15
-
Georg Ringer commented on patch set 1 07/11/11, 17:15
I would prefer that you didn't submit thisfunctionionality > functionalityclass.tslib_content.php:4140it will be a string given by stdWrap most of the timeclass.tslib_content.php:4144public, private?class.tslib_content.php:4155CGL: +1 tab for break;class.tslib_content.php:4164debug statement shouldn't be in there I guess? -
Chris topher commented on patch set 1 07/11/11, 17:15
I would prefer that you didn't submit this See inline comments.class.tslib_content.php:2332You don't mean "numberFormat", but "round" in the comment.class.tslib_content.php:2335The default value '' for $content seems to be wrong. The PHP functions ceil(), floor() and round() need the type float. Maybe better set the default to '0'.class.tslib_content.php:4152Add a space character between the brackets.class.tslib_content.php:4162$decimals must be an integer. Maybe you could still add a check for that (like you did for $floatVal)?class.tslib_content.php:4164Remove this line. -
Mr. Jenkins commented on patch set 1 07/11/11, 17:15
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1025/ : SUCCESS -
Stefan Neufeind commented on patch set 2 07/11/11, 17:15
Looks good to me, but someone else must approve -
Georg Ringer commented on patch set 2 07/11/11, 17:15
Looks good to me, but someone else must approve -
Chris topher commented on patch set 2 07/11/11, 17:15
Verified; Looks good to me, but someone else must approve -
Chris topher commented on patch set 2 07/11/11, 17:15
(1 inline comment) Hi Kilian, could you still add a check for $decimal being an integer? If it is not, you will get a warning "round() expects parameter 2 to be long, string given". Sorry that I did not notice that before. -
Mr. Jenkins commented on patch set 2 07/11/11, 17:15
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1037/ : SUCCESS -
Kilian Hann uploaded patch set 2 07/11/11, 17:15
-
Stefan Neufeind commented on patch set 4 07/11/11, 17:15
Verified; Looks good to me, but someone else must approve -
Stefan Neufeind commented on patch set 4 07/11/11, 17:15
@Philipp: number-format should be dependent on the locale set - though I'm not sure if that would require to the locale of the current page or only to the locale set for PHP
-
Xavier Perseguers commented on patch set 4 07/11/11, 17:15
(4 inline comments) Looks quite good but please take my comments into account -
Georg Ringer commented on patch set 4 07/11/11, 17:15
Looks good to me, but someone else must approve -
Steffen Gebert uploaded patch set 4 07/11/11, 17:15
-
Chris topher commented on patch set 4 07/11/11, 17:15
Verified; Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 4 07/11/11, 17:15
You should also mention, that this will only work on "english" numbers meaning if you have a point as decimal divider. Using the german notation with comma will not work.class.tslib_content.php:4161CGL says we need a comment here because of the fall trough -
Philipp Gampe commented on patch set 4 07/11/11, 17:15
Verified; Looks good to me, but someone else must approve works for me -
Jo Hasenau commented on patch set 4 07/11/11, 17:15
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 3 07/11/11, 17:15
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1057/ : SUCCESS -
Mr. Jenkins commented on patch set 4 07/11/11, 17:15
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1058/ : SUCCESS -
Kilian Hann uploaded patch set 3 07/11/11, 17:15
-
Andreas Wolf uploaded patch set 7 07/11/11, 17:15
-
Andreas Wolf uploaded patch set 8 07/11/11, 17:15
-
Andreas Wolf commented on patch set 8 V 0 07/11/11, 17:15
by team member; Looks good to me, approved Pushing after reviewing and adding unit tests. Documentation still has to be added. -
Stefan Neufeind commented on patch set 6 07/11/11, 17:15
PS: needs followup in stdWrap-documentation! -
Stefan Neufeind uploaded patch set 6 07/11/11, 17:15
-
Stefan Neufeind commented on patch set 6 07/11/11, 17:15
Verified; Looks good to me, but someone else must approve * rolled in the nitpicks from previous commit * code says it "defaults to round". So now we allow mytext.round = 1 as well * verified that it also works fine together with an additional numberFormat: page.5 = TEXT page.5.value = 2.753 page.5.round.roundType = round page.5.round.decimals = 2 page.5.numberFormat.decimals = 10 -
Stefan Neufeind commented on patch set 6 07/11/11, 17:15
(1 inline comment) don't think a fall-through-comment is needed -
Xavier Perseguers commented on patch set 5 3 comments 07/11/11, 17:15
Looks good to me, but someone else must approve Final +1 with comments taken into account. Will test afterwards and possibly merge it if +1 quota is OK -
Georg Ringer commented on patch set 5 V 0 07/11/11, 17:15
by team member; Looks good to me, approved -
Philipp Gampe commented on patch set 6 1 comment 07/11/11, 17:15
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 5 07/11/11, 17:15
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1090/ : SUCCESS -
Mr. Jenkins commented on patch set 6 07/11/11, 17:15
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1099/ : SUCCESS -
Mr. Jenkins commented on patch set 7 07/11/11, 17:15
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1111/ : SUCCESS -
Kilian Hann uploaded patch set 5 07/11/11, 17:15
-
Mr. Jenkins commented on patch set 8 07/11/11, 17:15
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1112/ : SUCCESS